Skip to content

Commit 631a456

Browse files
author
Sreesh Maheshwar
committed
Disable justication from test
1 parent 4bbd7b6 commit 631a456

1 file changed

Lines changed: 17 additions & 12 deletions

File tree

tests/integration/test_partitioning_key.py

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -729,18 +729,23 @@
729729
["special string"],
730730
Record(**{"special#string#field": "special string"}), # type: ignore
731731
"special%23string%23field=special%20string",
732-
f"""CREATE TABLE {identifier} (
733-
`special#string#field` string
734-
)
735-
USING iceberg
736-
PARTITIONED BY (
737-
identity(`special#string#field`)
738-
)
739-
""",
740-
f"""INSERT INTO {identifier}
741-
VALUES
742-
('special string')
743-
""",
732+
# Spark currently writes differently to PyIceberg w.r.t special column name sanitization so justification
733+
# (comparing expected value with Spark behavior) would fail: PyIceberg produces
734+
# Record[special_x23string_x23field='special string'], not Record[special#string#field='special string'].
735+
None,
736+
None,
737+
# f"""CREATE TABLE {identifier} (
738+
# `special#string#field` string
739+
# )
740+
# USING iceberg
741+
# PARTITIONED BY (
742+
# identity(`special#string#field`)
743+
# )
744+
# """,
745+
# f"""INSERT INTO {identifier}
746+
# VALUES
747+
# ('special string')
748+
# """,
744749
),
745750
],
746751
)

0 commit comments

Comments
 (0)