remove deprecation_message

Author: chrisqiqiu

pyiceberg/cli/console.py

@@ -33,7 +33,6 @@
 from pyiceberg.io import WAREHOUSE
 from pyiceberg.table import TableProperties
 from pyiceberg.table.refs import SnapshotRef, SnapshotRefType
-from pyiceberg.utils.deprecated import deprecation_message
 from pyiceberg.utils.properties import property_as_int
 
 
@@ -237,14 +236,9 @@ def location(ctx: Context, identifier: str) -> None:
 @click.pass_context
 @catch_exception()
 def version(ctx: Context) -> None:
-    """Print pyiceberg's installed package number (deprecated, use ``--version`` instead)."""
-    deprecation_message(
-        deprecated_in="0.11.0",
-        removed_in="1.0.0",
-        help_message="Please use `pyiceberg --version` instead of `pyiceberg version`",
-    )
+    """Print the installed pyiceberg package number (deprecated, use --version instead)."""
     click.echo(
-        "Deprecation warning: the `version` command is deprecated and will be removed in 1.0.0. "
+        "Deprecation warning: the `version` command is deprecated and will be removed in 0.13.0. "
         "Please use `pyiceberg --version` instead.",
         err=True,
     )

tests/cli/test_console.py

@@ -62,18 +62,14 @@ def test_hive_catalog_missing_uri_shows_helpful_error(mocker: MockFixture) -> No
     assert "'uri'" not in result.output
 
 
-@pytest.mark.filterwarnings(
-    "ignore:Deprecated in 0.11.0, will be removed in 1.0.0. "
-    "Please use `pyiceberg --version` instead of `pyiceberg version`:DeprecationWarning"
-)
 def test_version_does_not_load_catalog(mocker: MockFixture) -> None:
     mock_load_catalog = mocker.patch("pyiceberg.cli.console.load_catalog", side_effect=Exception("should not be called"))
 
     runner = CliRunner()
     result = runner.invoke(run, ["version"])
 
     assert result.exit_code == 0
-    assert __version__ in result.output
+    assert result.stdout == f"{__version__}\n"
     mock_load_catalog.assert_not_called()
 
 
@@ -85,14 +81,12 @@ def test_version_flag() -> None:
     assert result.output == f"{__version__}\n"
 
 
-def test_version_command_emits_deprecation_warning(mocker: MockFixture) -> None:
-    mocker.patch("pyiceberg.cli.console.load_catalog")
-
+def test_version_command_emits_deprecation_warning() -> None:
     runner = CliRunner()
-    with pytest.warns(DeprecationWarning, match="Please use `pyiceberg --version` instead of `pyiceberg version`"):
-        result = runner.invoke(run, ["version"])
+    result = runner.invoke(run, ["version"])
 
     assert result.exit_code == 0
+    assert __version__ in result.output
     assert "deprecated" in result.output.lower()
     assert "pyiceberg --version" in result.output