Use deprecation_message instead of deprecated for property deprecation

Author: ndrluis

pyiceberg/catalog/__init__.py

@@ -67,7 +67,7 @@
     RecursiveDict,
 )
 from pyiceberg.utils.config import Config, merge_config
-from pyiceberg.utils.deprecated import deprecated
+from pyiceberg.utils.deprecated import deprecation_message
 
 if TYPE_CHECKING:
     import pyarrow as pa
@@ -742,11 +742,11 @@ def __init__(self, name: str, **properties: str):
 
         for property_name in DEPRECATED_PROPERTY_NAMES:
             if self.properties.get(property_name):
-                deprecated(
+                deprecation_message(
                     deprecated_in="0.7.0",
                     removed_in="0.8.0",
                     help_message=f"The property {property_name} is deprecated. Please use properties that start with client., glue., and dynamo. instead",
-                )(lambda: None)()
+                )
 
     def create_table_transaction(
         self,

pyiceberg/catalog/rest.py

@@ -63,7 +63,6 @@
     CommitTableRequest,
     CommitTableResponse,
     CreateTableTransaction,
-    PropertyUtil,
     StagedTable,
     Table,
     TableIdentifier,
@@ -73,7 +72,7 @@
 from pyiceberg.typedef import EMPTY_DICT, UTF8, IcebergBaseModel, Identifier, Properties
 from pyiceberg.types import transform_dict_value_to_str
 from pyiceberg.utils.deprecated import deprecation_message
-from pyiceberg.utils.properties import property_as_bool
+from pyiceberg.utils.properties import get_first_property_value, property_as_bool
 
 if TYPE_CHECKING:
     import pyarrow as pa
@@ -303,7 +302,7 @@ def auth_url(self) -> str:
 
         self._warn_oauth_tokens_deprecation()
 
-        if url := PropertyUtil.get_first_property_value(self.properties, AUTH_URL, OAUTH2_SERVER_URI):
+        if url := get_first_property_value(self.properties, AUTH_URL, OAUTH2_SERVER_URI):
             return url
         else:
             return self.url(Endpoints.get_token, prefixed=False)
@@ -312,7 +311,7 @@ def _warn_oauth_tokens_deprecation(self) -> None:
         has_oauth_server_uri = OAUTH2_SERVER_URI in self.properties
         has_credential = CREDENTIAL in self.properties
         has_init_token = TOKEN in self.properties
-        has_sigv4_enabled = strtobool(self.properties.get(SIGV4, "false"))
+        has_sigv4_enabled = property_as_bool(self.properties, SIGV4, False)
 
         if not has_oauth_server_uri and (has_init_token or has_credential) and not has_sigv4_enabled:
             deprecation_message(