Skip to content

Commit 819a77d

Browse files
author
Jack Ye
committed
add more tests
1 parent d50e5ba commit 819a77d

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

tests/catalog/test_base.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,14 @@ def given_catalog_has_a_table(
291291
)
292292

293293

294-
def test_load_catalog_does_not_exist() -> None:
294+
def test_load_catalog_impl_not_full_path() -> None:
295+
with pytest.raises(ValueError) as exc_info:
296+
load_catalog("catalog", **{PY_CATALOG_IMPL: "CustomCatalog"})
297+
298+
assert "py-catalog-impl should be full path (module.CustomCatalog), got: CustomCatalog" in str(exc_info.value)
299+
300+
301+
def test_load_catalog_impl_does_not_exist() -> None:
295302
with pytest.raises(ValueError) as exc_info:
296303
load_catalog("catalog", **{PY_CATALOG_IMPL: "pyiceberg.does.not.exist.Catalog"})
297304

0 commit comments

Comments
 (0)