Skip to content

Commit 869754a

Browse files
committed
resolve review comments
1 parent 2990256 commit 869754a

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

pyiceberg/transforms.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -719,6 +719,7 @@ def transform(self, source: IcebergType) -> Callable[[S | None], S | None]:
719719
return lambda v: v
720720

721721
def can_transform(self, source: IcebergType) -> bool:
722+
# TODO: disallow VariantType when PyIceberg supports it.
722723
return source.is_primitive and not isinstance(source, (GeographyType, GeometryType))
723724

724725
def result_type(self, source: IcebergType) -> IcebergType:

tests/test_transforms.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ def test_identity_transform_unknown_type() -> None:
258258

259259

260260
@pytest.mark.parametrize("type_var", [GeometryType(), GeographyType()])
261-
def test_identity_transform_unsupported_type(type_var: PrimitiveType) -> None:
261+
def test_identity_can_transform_unsupported_type(type_var: PrimitiveType) -> None:
262262
assert not IdentityTransform().can_transform(type_var)
263263

264264

0 commit comments

Comments
 (0)