Commit 8f5e9ad
Address review nits: drop redundant ABC base, keep extracted bodies as faithful moves
- TableScan(BaseScan, ABC) -> TableScan(BaseScan): ABC is redundant since
BaseScan already extends it. No behavioural change (identical MRO,
ABCMeta metaclass, __abstractmethods__; TableScan stays non-instantiable).
- ManifestGroupPlanner.plan_manifest_entries / plan_files: restore the
baseline statement order and blank lines so the extracted bodies read as
verbatim moves of DataScan.scan_plan_helper / _plan_files_local.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent ecfa2fb commit 8f5e9ad
1 file changed
Lines changed: 7 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1907 | 1907 | | |
1908 | 1908 | | |
1909 | 1909 | | |
1910 | | - | |
| 1910 | + | |
1911 | 1911 | | |
1912 | 1912 | | |
1913 | 1913 | | |
| |||
2274 | 2274 | | |
2275 | 2275 | | |
2276 | 2276 | | |
| 2277 | + | |
2277 | 2278 | | |
| 2279 | + | |
2278 | 2280 | | |
2279 | 2281 | | |
2280 | 2282 | | |
2281 | 2283 | | |
2282 | 2284 | | |
2283 | 2285 | | |
| 2286 | + | |
2284 | 2287 | | |
| 2288 | + | |
2285 | 2289 | | |
2286 | 2290 | | |
2287 | 2291 | | |
| |||
2305 | 2309 | | |
2306 | 2310 | | |
2307 | 2311 | | |
2308 | | - | |
2309 | | - | |
2310 | 2312 | | |
2311 | 2313 | | |
2312 | 2314 | | |
| 2315 | + | |
| 2316 | + | |
2313 | 2317 | | |
2314 | 2318 | | |
2315 | 2319 | | |
| |||
0 commit comments