test console with sqlcatalog

Author: kevinjqliu

pyiceberg/catalog/__init__.py

@@ -596,7 +596,7 @@ def identifier_to_database_and_table(
     ) -> Tuple[str, str]:
         tuple_identifier = Catalog.identifier_to_tuple(identifier)
         if len(tuple_identifier) != 2:
-            raise err(f"Invalid path, hierarchical namespaces are not supported: {identifier}")
+            raise err(f"Table does not exist: {tuple_identifier}")
 
         return tuple_identifier[0], tuple_identifier[1]
 

pyiceberg/catalog/sql.py

@@ -177,7 +177,7 @@ def create_table(
 
         database_name, table_name = self.identifier_to_database_and_table(identifier)
         if not self._namespace_exists(database_name):
-            raise NoSuchNamespaceError(f"Namespace does not exist: {database_name}")
+            self.create_namespace(database_name)
 
         location = self._resolve_table_location(location, database_name, table_name)
         metadata_location = self._get_metadata_location(location=location)
@@ -265,7 +265,7 @@ def load_table(self, identifier: Union[str, Identifier]) -> Table:
             result = session.scalar(stmt)
         if result:
             return self._convert_orm_to_iceberg(result)
-        raise NoSuchTableError(f"Table does not exist: {database_name}.{table_name}")
+        raise NoSuchTableError(f"Table does not exist: {identifier_tuple}")
 
     def drop_table(self, identifier: Union[str, Identifier]) -> None:
         """Drop a table.
@@ -288,7 +288,7 @@ def drop_table(self, identifier: Union[str, Identifier]) -> None:
                     )
                 )
                 if res.rowcount < 1:
-                    raise NoSuchTableError(f"Table does not exist: {database_name}.{table_name}")
+                    raise NoSuchTableError(f"Table does not exist: {identifier_tuple}")
             else:
                 try:
                     tbl = (
@@ -303,7 +303,7 @@ def drop_table(self, identifier: Union[str, Identifier]) -> None:
                     )
                     session.delete(tbl)
                 except NoResultFound as e:
-                    raise NoSuchTableError(f"Table does not exist: {database_name}.{table_name}") from e
+                    raise NoSuchTableError(f"Table does not exist: {identifier_tuple}") from e
             session.commit()
 
     def rename_table(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> Table:
@@ -503,6 +503,8 @@ def drop_namespace(self, namespace: Union[str, Identifier]) -> None:
                     )
                 )
                 session.commit()
+        else:
+            raise NoSuchNamespaceError(f"Namespace does not exist: {self.identifier_to_tuple(namespace)}")
 
     def list_tables(self, namespace: Union[str, Identifier]) -> List[Identifier]:
         """List tables under the given namespace in the catalog.
@@ -539,6 +541,10 @@ def list_namespaces(self, namespace: Union[str, Identifier] = ()) -> List[Identi
         Raises:
             NoSuchNamespaceError: If a namespace with the given name does not exist.
         """
+        # Hierarchical namespace is not supported. Return an empty list
+        if namespace:
+            return []
+
         if namespace and not self._namespace_exists(namespace):
             raise NoSuchNamespaceError(f"Namespace does not exist: {namespace}")
 
@@ -575,7 +581,9 @@ def load_namespace_properties(self, namespace: Union[str, Identifier]) -> Proper
             IcebergNamespaceProperties.catalog_name == self.name, IcebergNamespaceProperties.namespace == database_name
         )
         with Session(self.engine) as session:
-            result = session.scalars(stmt)
+            result = list(session.scalars(stmt))
+            if len(result) == 0:
+                raise NoSuchNamespaceError(f"Namespace does not exist: {namespace}")
             return {props.property_key: props.property_value for props in result}
 
     def update_namespace_properties(
@@ -594,7 +602,7 @@ def update_namespace_properties(
         """
         database_name = self.identifier_to_database(namespace)
         if not self._namespace_exists(database_name):
-            raise NoSuchNamespaceError(f"Database {database_name} does not exists")
+            raise NoSuchNamespaceError(f"Namespace does not exist: {self.identifier_to_tuple(namespace)}")
 
         current_properties = self.load_namespace_properties(namespace=namespace)
         properties_update_summary = self._get_updated_props_and_update_summary(