Skip to content

Commit 96247c9

Browse files
committed
test: add test case for create_match_filter without null
1 parent 021b3d7 commit 96247c9

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

tests/table/test_upsert.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -447,6 +447,11 @@ def test_create_match_filter_single_condition() -> None:
447447
@pytest.mark.parametrize(
448448
"data, expected",
449449
[
450+
pytest.param(
451+
[{"x": 1.0}, {"x": 2.0}, {"x": 3.0}],
452+
In(Reference(name="x"), {DoubleLiteral(1.0), DoubleLiteral(2.0), DoubleLiteral(3.0)}),
453+
id="single-column-without-null",
454+
),
450455
pytest.param(
451456
[{"x": 1.0}, {"x": 2.0}, {"x": None}, {"x": 4.0}, {"x": float("nan")}],
452457
Or(
@@ -456,7 +461,7 @@ def test_create_match_filter_single_condition() -> None:
456461
right=In(Reference(name="x"), {DoubleLiteral(1.0), DoubleLiteral(2.0), DoubleLiteral(4.0)}),
457462
),
458463
),
459-
id="single-column",
464+
id="single-column-with-null",
460465
),
461466
pytest.param(
462467
[
@@ -494,11 +499,11 @@ def test_create_match_filter_single_condition() -> None:
494499
),
495500
),
496501
),
497-
id="multi-column",
502+
id="multi-column-with-null",
498503
),
499504
],
500505
)
501-
def test_create_match_filter_with_nulls(data: list[dict[str, Any]], expected: BooleanExpression) -> None:
506+
def test_create_match_filter(data: list[dict[str, Any]], expected: BooleanExpression) -> None:
502507
schema = pa.schema([pa.field("x", pa.float64()), pa.field("y", pa.float64())])
503508
table = pa.Table.from_pylist(data, schema=schema)
504509
join_cols = sorted({col for record in data for col in record})

0 commit comments

Comments
 (0)