Skip to content

Commit a371077

Browse files
FokkoHonahX
authored andcommitted
docstring: Fix missing commit (#432)
1 parent c207cc6 commit a371077

File tree

6 files changed

+8
-2
lines changed

6 files changed

+8
-2
lines changed

pyiceberg/catalog/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -385,6 +385,8 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons
385385
386386
Raises:
387387
NoSuchTableError: If a table with the given identifier does not exist.
388+
CommitFailedException: Requirement not met, or a conflict with a concurrent commit.
389+
CommitStateUnknownException: Failed due to an internal exception on the side of the catalog.
388390
"""
389391

390392
@abstractmethod

pyiceberg/catalog/dynamodb.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons
208208
209209
Raises:
210210
NoSuchTableError: If a table with the given identifier does not exist.
211+
CommitFailedException: Requirement not met, or a conflict with a concurrent commit.
211212
"""
212213
raise NotImplementedError
213214

pyiceberg/catalog/glue.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons
404404
405405
Raises:
406406
NoSuchTableError: If a table with the given identifier does not exist.
407-
CommitFailedException: If the commit failed.
407+
CommitFailedException: Requirement not met, or a conflict with a concurrent commit.
408408
"""
409409
identifier_tuple = self.identifier_to_tuple_without_catalog(
410410
tuple(table_request.identifier.namespace.root + [table_request.identifier.name])

pyiceberg/catalog/hive.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -360,6 +360,7 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons
360360
361361
Raises:
362362
NoSuchTableError: If a table with the given identifier does not exist.
363+
CommitFailedException: Requirement not met, or a conflict with a concurrent commit.
363364
"""
364365
identifier_tuple = self.identifier_to_tuple_without_catalog(
365366
tuple(table_request.identifier.namespace.root + [table_request.identifier.name])

pyiceberg/catalog/rest.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -568,6 +568,8 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons
568568
569569
Raises:
570570
NoSuchTableError: If a table with the given identifier does not exist.
571+
CommitFailedException: Requirement not met, or a conflict with a concurrent commit.
572+
CommitStateUnknownException: Failed due to an internal exception on the side of the catalog.
571573
"""
572574
response = self._session.post(
573575
self.url(Endpoints.update_table, prefixed=True, **self._split_identifier_for_path(table_request.identifier)),

pyiceberg/catalog/sql.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons
373373
374374
Raises:
375375
NoSuchTableError: If a table with the given identifier does not exist.
376-
CommitFailedException: If the commit failed.
376+
CommitFailedException: Requirement not met, or a conflict with a concurrent commit.
377377
"""
378378
identifier_tuple = self.identifier_to_tuple_without_catalog(
379379
tuple(table_request.identifier.namespace.root + [table_request.identifier.name])

0 commit comments

Comments
 (0)