Skip to content

Commit afb1f51

Browse files
committed
Fix mypy: proxies type must be Mapping, not MutableMapping
requests' HTTPAdapter.send declares proxies as Mapping[str, str] | None (via types-requests). Overriding with the more specific MutableMapping is an invalid override under mypy 1.18 strict mode. Signed-off-by: rahulsmahadev <rahul.mahadev@databricks.com>
1 parent 6fb87ff commit afb1f51

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

pyiceberg/catalog/rest/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from __future__ import annotations
1818

1919
from collections import deque
20-
from collections.abc import MutableMapping
20+
from collections.abc import Mapping
2121
from enum import Enum
2222
from typing import (
2323
TYPE_CHECKING,
@@ -425,7 +425,7 @@ def send(
425425
timeout: None | float | tuple[float, float] | tuple[float, None] = None,
426426
verify: bool | str = True,
427427
cert: None | bytes | str | tuple[bytes | str, bytes | str] = None,
428-
proxies: MutableMapping[str, str] | None = None,
428+
proxies: Mapping[str, str] | None = None,
429429
) -> Response:
430430
if timeout is None:
431431
timeout = self._timeout

0 commit comments

Comments
 (0)