Tighten replace_table_transaction input validation

- Wrap int() parse of the format-version property in try/except so a
  non-numeric value yields a domain-meaningful ValueError instead of
  Python's opaque "invalid literal for int()".

- Reject a resolved location of empty string. Previously a caller
  passing location="/" silently produced location="" after rstrip,
  which would later land as SetLocationUpdate(location="").

Author: smaheshwar-pltr

pyiceberg/catalog/__init__.py

@@ -505,14 +505,19 @@ def _replace_staged_table(
         existing_table = self.load_table(identifier)
         existing_metadata = existing_table.metadata
 
-        requested_format_version = properties.get(TableProperties.FORMAT_VERSION)
-        if requested_format_version is not None and int(requested_format_version) < existing_metadata.format_version:
-            raise ValueError(
-                f"Cannot downgrade format-version from {existing_metadata.format_version} to {requested_format_version}"
-            )
-        resolved_format_version = (
-            int(requested_format_version) if requested_format_version is not None else existing_metadata.format_version
-        )
+        raw_format_version = properties.get(TableProperties.FORMAT_VERSION)
+        if raw_format_version is not None:
+            try:
+                requested_format_version = int(raw_format_version)
+            except (TypeError, ValueError) as exc:
+                raise ValueError(f"Invalid format-version property: {raw_format_version!r}") from exc
+            if requested_format_version < existing_metadata.format_version:
+                raise ValueError(
+                    f"Cannot downgrade format-version from {existing_metadata.format_version} to {requested_format_version}"
+                )
+            resolved_format_version = requested_format_version
+        else:
+            resolved_format_version = existing_metadata.format_version
         iceberg_schema = self._convert_schema_if_needed(schema, cast(TableVersion, resolved_format_version))
         iceberg_schema.check_format_version_compatibility(cast(TableVersion, resolved_format_version))
 
@@ -533,6 +538,8 @@ def _replace_staged_table(
         fresh_sort_order = assign_fresh_sort_order_ids(sort_order, iceberg_schema, fresh_schema)
 
         resolved_location = location.rstrip("/") if location else existing_metadata.location
+        if not resolved_location:
+            raise ValueError("Resolved table location must not be empty")
 
         staged_table = StagedTable(
             identifier=existing_table.name(),

tests/catalog/test_catalog_behaviors.py

@@ -638,6 +638,18 @@ def test_replace_table_rejects_format_version_downgrade(catalog: Catalog, test_t
         catalog.replace_table_transaction(test_table_identifier, schema=schema, properties={"format-version": "1"})
 
 
+def test_replace_table_rejects_non_numeric_format_version(catalog: Catalog, test_table_identifier: Identifier) -> None:
+    _, schema = _create_simple_table(catalog, test_table_identifier)
+    with pytest.raises(ValueError, match="Invalid format-version property"):
+        catalog.replace_table_transaction(test_table_identifier, schema=schema, properties={"format-version": "two"})
+
+
+def test_replace_table_rejects_empty_location(catalog: Catalog, test_table_identifier: Identifier) -> None:
+    _, schema = _create_simple_table(catalog, test_table_identifier)
+    with pytest.raises(ValueError, match="location must not be empty"):
+        catalog.replace_table_transaction(test_table_identifier, schema=schema, location="/")
+
+
 @pytest.mark.parametrize("location_kind", ["inherit", "explicit", "trailing-slash"])
 def test_replace_table_location(catalog: Catalog, test_table_identifier: Identifier, tmp_path: Path, location_kind: str) -> None:
     _, schema = _create_simple_table(catalog, test_table_identifier)