fix(glue): Extract S3 Tables connection type constant and simplify _create_table_s3tables signature

- Extract "aws:s3tables" string literal into GLUE_CONNECTION_S3_TABLES constant
- Remove redundant database_name/table_name params from _create_table_s3tables;
  derive them from identifier inside the method instead

Author: jamesbornholt

pyiceberg/catalog/glue.py

@@ -130,6 +130,7 @@
 GLUE_SESSION_TOKEN = "glue.session-token"
 GLUE_MAX_RETRIES = "glue.max-retries"
 GLUE_RETRY_MODE = "glue.retry-mode"
+GLUE_CONNECTION_S3_TABLES = "aws:s3tables"
 
 MAX_RETRIES = 10
 STANDARD_RETRY_MODE = "standard"
@@ -438,13 +439,11 @@ def _is_s3tables_database(self, database_name: str) -> bool:
             return False
         database = database_response["Database"]
         federated = database.get("FederatedDatabase", {})
-        return (federated.get("ConnectionType") or "").lower() == "aws:s3tables"
+        return (federated.get("ConnectionType") or "").lower() == GLUE_CONNECTION_S3_TABLES
 
     def _create_table_s3tables(
         self,
         identifier: str | Identifier,
-        database_name: str,
-        table_name: str,
         schema: Union[Schema, "pa.Schema"],
         location: str | None,
         partition_spec: PartitionSpec,
@@ -463,6 +462,8 @@ def _create_table_s3tables(
 
         On failure, the table created in step 1 is deleted.
         """
+        database_name, table_name = self.identifier_to_database_and_table(identifier)
+
         if location is not None:
             raise ValueError(
                 f"Cannot specify a location for S3 Tables table {database_name}.{table_name}. "
@@ -559,8 +560,6 @@ def create_table(
         if self._is_s3tables_database(database_name):
             return self._create_table_s3tables(
                 identifier=identifier,
-                database_name=database_name,
-                table_name=table_name,
                 schema=schema,
                 location=location,
                 partition_spec=partition_spec,

tests/catalog/test_glue.py

@@ -21,7 +21,7 @@
 import pytest
 from moto import mock_aws
 
-from pyiceberg.catalog.glue import GlueCatalog
+from pyiceberg.catalog.glue import GLUE_CONNECTION_S3_TABLES, GlueCatalog
 from pyiceberg.exceptions import (
     NamespaceAlreadyExistsError,
     NamespaceNotEmptyError,
@@ -1013,7 +1013,7 @@ def _create_s3tables_database(catalog: GlueCatalog, database_name: str) -> None:
             "Name": database_name,
             "FederatedDatabase": {
                 "Identifier": "arn:aws:s3tables:us-east-1:123456789012:bucket/my-bucket",
-                "ConnectionType": "aws:s3tables",
+                "ConnectionType": GLUE_CONNECTION_S3_TABLES,
             },
         }
     )