Skip to content

Commit df00b11

Browse files
Drop implementation-coupled comment from no-snapshot test
Per review: the test asserts behaviour (a table with no current snapshot plans zero files across every read path); the rationale for adding it belongs in the PR discussion, not an in-code comment tied to internals. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 8f5e9ad commit df00b11

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

tests/table/test_init.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -339,9 +339,6 @@ def test_table_scan_projection_unknown_column(table_v2: Table) -> None:
339339

340340

341341
def test_data_scan_plan_files_no_current_snapshot(example_table_metadata_no_snapshot_v1: dict[str, Any]) -> None:
342-
# A table with no current snapshot must plan zero files (rather than raising) across every
343-
# read path. DataScan routes local planning through ManifestGroupPlanner, which has no
344-
# snapshot guard of its own, so the guard lives in DataScan._plan_files_local.
345342
table = Table(
346343
identifier=("default", "test_no_snapshot"),
347344
metadata=TableMetadataV1(**example_table_metadata_no_snapshot_v1),

0 commit comments

Comments
 (0)