Skip to content

Commit e405573

Browse files
authored
Rename _scan_plan_helper method to _plan_manifest_entries (#3579)
# Rationale for this change The method name should describe what it does. - Follow-up of #3553 ## Are these changes tested? Yes ## Are there any user-facing changes? No, this is an internal method.
1 parent 09db25b commit e405573

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

pyiceberg/table/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2224,7 +2224,7 @@ def _manifest_planner(self) -> ManifestGroupPlanner:
22242224
def partition_filters(self) -> KeyDefaultDict[int, BooleanExpression]:
22252225
return self._manifest_planner.partition_filters
22262226

2227-
def _scan_plan_helper(self) -> Iterator[list[ManifestEntry]]:
2227+
def _plan_manifest_entries(self) -> Iterator[list[ManifestEntry]]:
22282228
"""Filter and return manifest entries based on partition and metrics evaluators.
22292229
22302230
Returns:

pyiceberg/table/inspect.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ def partitions(
311311

312312
partitions_map: dict[tuple[str, Any], Any] = {}
313313

314-
for entry in itertools.chain.from_iterable(scan._scan_plan_helper()):
314+
for entry in itertools.chain.from_iterable(scan._plan_manifest_entries()):
315315
partition = entry.data_file.partition
316316
partition_record_dict = {
317317
field.name: partition[pos] for pos, field in enumerate(self.tbl.metadata.specs()[entry.data_file.spec_id].fields)

0 commit comments

Comments
 (0)