Commit e649f95
committed
Extend replace_table to all catalogs, harden semantics
- Move replace_table_transaction implementations to MetastoreCatalog and
RestCatalog; keep stub + shared _replace_staged_table helper on Catalog
so out-of-tree subclasses don't break.
- Emit UpgradeFormatVersionUpdate when properties bump format-version,
matching Java's TableMetadata.buildReplacement.
- Always emit SetCurrentSchema / SetDefaultPartitionSpec /
SetDefaultSortOrder, mirroring RESTSessionCatalog.replaceTransaction.
- Handle v1 partition specs by carrying forward removed fields as
VoidTransform (v1 specs are append-only).
- Reject view collisions before replacing.
- Assign fresh schema_id / spec_id / order_id on Add* updates so
AddSchemaUpdate / AddPartitionSpecUpdate / AddSortOrderUpdate produce
uniquely-keyed entries.
- Tests: behaviour now covered in tests/catalog/test_catalog_behaviors.py
parametrized across InMemoryCatalog + SqlCatalog. test_rest.py keeps
only REST wire-specific cases (payload shape, 404, view collision,
immediate commit). One end-to-end smoke test remains in
tests/integration/test_rest_catalog.py.
- Add docs section in mkdocs/docs/api.md.1 parent 41da8bd commit e649f95
10 files changed
Lines changed: 539 additions & 996 deletions
File tree
- mkdocs/docs
- pyiceberg
- catalog
- rest
- table
- tests
- catalog
- integration
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
188 | 225 | | |
189 | 226 | | |
190 | 227 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
47 | 51 | | |
48 | 52 | | |
49 | 53 | | |
| |||
56 | 60 | | |
57 | 61 | | |
58 | 62 | | |
59 | | - | |
| 63 | + | |
60 | 64 | | |
61 | 65 | | |
62 | 66 | | |
| |||
324 | 328 | | |
325 | 329 | | |
326 | 330 | | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
327 | 345 | | |
328 | 346 | | |
329 | 347 | | |
| |||
445 | 463 | | |
446 | 464 | | |
447 | 465 | | |
448 | | - | |
449 | 466 | | |
450 | 467 | | |
451 | 468 | | |
| |||
473 | 490 | | |
474 | 491 | | |
475 | 492 | | |
| 493 | + | |
476 | 494 | | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
477 | 498 | | |
478 | | - | |
479 | 499 | | |
480 | 500 | | |
481 | 501 | | |
| |||
503 | 523 | | |
504 | 524 | | |
505 | 525 | | |
| 526 | + | |
506 | 527 | | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
507 | 583 | | |
508 | 584 | | |
509 | 585 | | |
| |||
985 | 1061 | | |
986 | 1062 | | |
987 | 1063 | | |
988 | | - | |
989 | | - | |
990 | | - | |
991 | | - | |
992 | | - | |
993 | | - | |
994 | | - | |
995 | | - | |
996 | | - | |
997 | | - | |
998 | | - | |
999 | | - | |
1000 | 1064 | | |
1001 | 1065 | | |
1002 | 1066 | | |
| |||
1007 | 1071 | | |
1008 | 1072 | | |
1009 | 1073 | | |
1010 | | - | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
| 1079 | + | |
| 1080 | + | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
1011 | 1086 | | |
1012 | 1087 | | |
1013 | 1088 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | 31 | | |
33 | 32 | | |
34 | 33 | | |
| |||
69 | 68 | | |
70 | 69 | | |
71 | 70 | | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | 71 | | |
97 | 72 | | |
98 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
34 | 42 | | |
35 | 43 | | |
36 | 44 | | |
| |||
72 | 80 | | |
73 | 81 | | |
74 | 82 | | |
75 | | - | |
76 | 83 | | |
77 | | - | |
| 84 | + | |
78 | 85 | | |
79 | 86 | | |
80 | 87 | | |
| |||
990 | 997 | | |
991 | 998 | | |
992 | 999 | | |
993 | | - | |
994 | | - | |
995 | | - | |
996 | | - | |
997 | | - | |
998 | | - | |
999 | | - | |
1000 | | - | |
1001 | | - | |
1002 | | - | |
1003 | | - | |
1004 | | - | |
1005 | | - | |
1006 | | - | |
1007 | | - | |
1008 | | - | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
1009 | 1003 | | |
1010 | | - | |
1011 | | - | |
1012 | | - | |
1013 | | - | |
1014 | | - | |
1015 | | - | |
1016 | | - | |
1017 | | - | |
1018 | | - | |
1019 | | - | |
1020 | | - | |
1021 | | - | |
1022 | | - | |
1023 | | - | |
1024 | | - | |
1025 | | - | |
1026 | 1004 | | |
1027 | 1005 | | |
1028 | 1006 | | |
1029 | | - | |
| 1007 | + | |
1030 | 1008 | | |
1031 | 1009 | | |
1032 | 1010 | | |
| |||
0 commit comments