Collapse duplicate replace_table_transaction onto Catalog

Before: replace_table_transaction was @AbstractMethod on Catalog, with
identical 9-line bodies on MetastoreCatalog and RestCatalog (only REST
added @Retry). The bodies were identical because the only thing that
could vary - the load_table to fetch existing metadata - already lives
inside the shared _replace_staged_table helper.

This is unlike create_table_transaction, which legitimately needs
per-catalog impls (REST uses a server-side stage_create=True endpoint,
Metastore stages locally). Replace has no analogous server-side staging,
so the abstract-and-duplicate structure earned no symmetry.

After: Catalog.replace_table_transaction is concrete and owns the
helper-and-construct flow. RestCatalog keeps a thin @retry-only
override that delegates to super(). MetastoreCatalog drops its
override entirely. NoopCatalog keeps its explicit NotImplementedError
stub for consistency with its other every-method-explicit stubs.

Net -22 LOC, one less abstract surface to keep in sync.

Author: smaheshwar-pltr

pyiceberg/catalog/__init__.py

@@ -449,7 +449,6 @@ def create_table_if_not_exists(
         except TableAlreadyExistsError:
             return self.load_table(identifier)
 
-    @abstractmethod
     def replace_table_transaction(
         self,
         identifier: str | Identifier,
@@ -481,6 +480,17 @@ def replace_table_transaction(
         Raises:
             NoSuchTableError: If the table does not exist.
         """
+        staged_table, fresh_schema, fresh_spec, fresh_sort_order, resolved_location = self._replace_staged_table(
+            identifier, schema, location, partition_spec, sort_order, properties
+        )
+        return ReplaceTableTransaction(
+            table=staged_table,
+            new_schema=fresh_schema,
+            new_spec=fresh_spec,
+            new_sort_order=fresh_sort_order,
+            new_location=resolved_location,
+            new_properties=properties,
+        )
 
     def _replace_staged_table(
         self,
@@ -1030,28 +1040,6 @@ def create_table_transaction(
             self._create_staged_table(identifier, schema, location, partition_spec, sort_order, properties)
         )
 
-    @override
-    def replace_table_transaction(
-        self,
-        identifier: str | Identifier,
-        schema: Schema | pa.Schema,
-        location: str | None = None,
-        partition_spec: PartitionSpec = UNPARTITIONED_PARTITION_SPEC,
-        sort_order: SortOrder = UNSORTED_SORT_ORDER,
-        properties: Properties = EMPTY_DICT,
-    ) -> ReplaceTableTransaction:
-        staged_table, fresh_schema, fresh_spec, fresh_sort_order, resolved_location = self._replace_staged_table(
-            identifier, schema, location, partition_spec, sort_order, properties
-        )
-        return ReplaceTableTransaction(
-            table=staged_table,
-            new_schema=fresh_schema,
-            new_spec=fresh_spec,
-            new_sort_order=fresh_sort_order,
-            new_location=resolved_location,
-            new_properties=properties,
-        )
-
     @override
     def table_exists(self, identifier: str | Identifier) -> bool:
         try:

pyiceberg/catalog/rest/__init__.py

@@ -969,17 +969,7 @@ def replace_table_transaction(
         sort_order: SortOrder = UNSORTED_SORT_ORDER,
         properties: Properties = EMPTY_DICT,
     ) -> ReplaceTableTransaction:
-        staged_table, fresh_schema, fresh_spec, fresh_sort_order, resolved_location = self._replace_staged_table(
-            identifier, schema, location, partition_spec, sort_order, properties
-        )
-        return ReplaceTableTransaction(
-            table=staged_table,
-            new_schema=fresh_schema,
-            new_spec=fresh_spec,
-            new_sort_order=fresh_sort_order,
-            new_location=resolved_location,
-            new_properties=properties,
-        )
+        return super().replace_table_transaction(identifier, schema, location, partition_spec, sort_order, properties)
 
     @override
     @retry(**_RETRY_ARGS)