Skip to content

Drop support for Python 3.8 #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 5 commits into from
Oct 8, 2024
Merged

Drop support for Python 3.8 #1221

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fbbd74f
Drop support for Python 3.8
raulcd Oct 6, 2024
ac149f1
Run poetry lock --no-update
raulcd Oct 6, 2024
96e44df
Add usage of Python 3.9 on Ubuntu 20.04
raulcd Oct 6, 2024
be160f6
Update Ubuntu to 22.04 on Integration tests
raulcd Oct 7, 2024
aeed712
Add Python 3.10 to python-release workflow
raulcd Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
python: ['3.8', '3.9', '3.10', '3.11', '3.12']
python: ['3.9', '3.10', '3.11', '3.12']

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ concurrency:

jobs:
integration-test:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/python-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- uses: actions/setup-python@v5
with:
python-version: |
3.8
3.9
3.11
Comment thread
raulcd marked this conversation as resolved.
3.12

Expand All @@ -69,7 +69,7 @@ jobs:
env:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.8,<3.13"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.9,<3.13"
CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1"
CIBW_TEST_EXTRAS: "s3fs,glue"
CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
Expand Down
2 changes: 1 addition & 1 deletion mkdocs/docs/contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ Deprecated in 0.1.0, will be removed in 0.2.0. The old_property is deprecated. P

For the type annotation the types from the `Typing` package are used.

PyIceberg offers support from Python 3.8 onwards, we can't use the [type hints from the standard collections](https://peps.python.org/pep-0585/).
PyIceberg offers support from Python 3.9 onwards, we can't use the [type hints from the standard collections](https://peps.python.org/pep-0585/).

@kevinjqliu kevinjqliu Oct 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a paragraph about dropping 3.8 support at version 0.x (whatever we release this commit as)

@raulcd raulcd Oct 7, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kevinjqliu, I am unsure I understand where you want me to add this paragraph. Are you suggesting to add it to the mkdocs/docs/contributing.md file? I thought the changelog would be generated from the issues/commits is there any other place where the changelogs / guidelines should be added for that?

@kevinjqliu kevinjqliu Oct 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry about the confusion, i didnt see this is the contributing doc. in that case, this isn't needed.

i thought this was the docs on how to use pyiceberg, in which case we should mention that 3.8 support is dropped in this next release


## Third party libraries

Expand Down
145 changes: 6 additions & 139 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ license = "Apache License 2.0"
classifiers = [
"License :: OSI Approved :: Apache Software License",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand All @@ -50,7 +49,7 @@ include = [
]

[tool.poetry.dependencies]
python = "^3.8, <3.13, !=3.9.7"
python = "^3.9, <3.13, !=3.9.7"
mmh3 = ">=4.0.0,<5.0.0"
requests = ">=2.20.0,<3.0.0"
click = ">=7.1.1,<9.0.0"
Expand Down Expand Up @@ -81,7 +80,6 @@ sqlalchemy = { version = "^2.0.18", optional = true }
getdaft = { version = ">=0.2.12", optional = true }
numpy = [
{ version = "1.26.0", python = ">=3.9,<3.13", optional = true },
{ version = "1.24.4", python = ">=3.8,<3.9", optional = true }
]
cachetools = "^5.5.0"

Expand Down