Skip to content

fix: list_tables method in glue catalog now only return tables. #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HonahX merged 2 commits into from
Oct 31, 2024
Merged

fix: list_tables method in glue catalog now only return tables. #1258

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79b38f2
fix: list_tables method only return tables
omkenge Oct 28, 2024
987c41a
Update pyiceberg/catalog/glue.py
omkenge Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyiceberg/catalog/glue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,4 +784,4 @@ def drop_view(self, identifier: Union[str, Identifier]) -> None:

@staticmethod
def __is_iceberg_table(table: TableTypeDef) -> bool:
return table["Parameters"] is not None and table["Parameters"][TABLE_TYPE].lower() == ICEBERG
return table.get("Parameters", {}).get("table_type", "").lower() == "iceberg"
Comment thread
omkenge marked this conversation as resolved.
Outdated