Skip to content

fix KeyError raised by add_files when parquet file doe not have column stats #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 5 commits into from
Nov 25, 2024
Merged

fix KeyError raised by add_files when parquet file doe not have column stats #1354

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fe20d4d
fix KeyError, by switching del to pop
binayakd Nov 21, 2024
6de54c6
added unit test
binayakd Nov 21, 2024
5c676b8
update test
binayakd Nov 22, 2024
939d325
fix python 3.9 compatibility, and refactor test
binayakd Nov 23, 2024
e26ef50
update test
binayakd Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyiceberg/io/pyarrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2397,8 +2397,8 @@ def data_file_statistics_from_parquet_metadata(
split_offsets.sort()

for field_id in invalidate_col:
del col_aggs[field_id]
del null_value_counts[field_id]
col_aggs.pop(field_id, None)
null_value_counts.pop(field_id, None)

return DataFileStatistics(
record_count=parquet_metadata.num_rows,
Expand Down