Skip to content

infra: allow rerun make install without prompt #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 8 commits into from
Jan 30, 2026
Merged

infra: allow rerun make install without prompt #2979

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a854129
allow rerun `make install` without prompt
kevinjqliu Jan 29, 2026
24e0033
let uv handle venv
kevinjqliu Jan 29, 2026
16dfc52
conditionally reinstall package
kevinjqliu Jan 29, 2026
c07a9f9
fix ci
kevinjqliu Jan 29, 2026
d017475
fix ci again
kevinjqliu Jan 29, 2026
0eaa3ec
add back
kevinjqliu Jan 29, 2026
7db6183
Merge remote-tracking branch 'origin/main' into kevinjqliu/fix-make-i…
kevinjqliu Jan 30, 2026
a1dcaed
fmt
kevinjqliu Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,15 @@ install-uv: ## Ensure uv is installed
echo "uv is already installed."; \
fi

setup-venv: ## Create virtual environment
uv venv $(PYTHON_ARG)
setup-venv: ## Create virtual environment (if not exists)
Comment thread
kevinjqliu marked this conversation as resolved.
Outdated
@if [ ! -d ".venv" ]; then \
Comment thread
kevinjqliu marked this conversation as resolved.
Outdated
uv venv $(PYTHON_ARG); \
else \
echo "Virtual environment already exists at .venv"; \
fi

install-dependencies: setup-venv ## Install all dependencies including extras
uv sync $(PYTHON_ARG) --all-extras --reinstall
uv sync $(PYTHON_ARG) --all-extras
Comment thread
kevinjqliu marked this conversation as resolved.

install-hooks: ## Install pre-commit hooks
uv run $(PYTHON_ARG) prek install
Expand Down