Added implementation to delete file and CLI to add file#2997
Added implementation to delete file and CLI to add file#2997subkanthi wants to merge 10 commits intoapache:mainfrom
Conversation
|
|
||
| result: dict[str, DataFile] = {} | ||
| for manifest in snapshot.manifests(io): | ||
| if manifest.content == ManifestContent.DATA: |
There was a problem hiding this comment.
Should we also drop related deletes?
| return [f.result() for f in futures if f.result()] | ||
|
|
||
|
|
||
| def _get_data_files_from_snapshot( |
There was a problem hiding this comment.
Can we use metadata tables for this? I'd like to avoid functions like these since they do not parallelize
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Closes #2787
Rationale for this change
To be in parity with java and rust to support delete files.
Are these changes tested?
Yes
Are there any user-facing changes?
Yes