Skip to content

add github add to check md link#324

Merged
Fokko merged 4 commits into
apache:mainfrom
kevinjqliu:kevinjqliu/markdown-link-check
Feb 29, 2024
Merged

add github add to check md link#324
Fokko merged 4 commits into
apache:mainfrom
kevinjqliu:kevinjqliu/markdown-link-check

Conversation

@kevinjqliu

Copy link
Copy Markdown
Contributor

No description provided.

@Fokko Fokko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjqliu for raising this PR

@bitsondatadev How cool is this!?

@kevinjqliu

Copy link
Copy Markdown
Contributor Author

Here's the result from the GitHub Action run from my fork
https://github.com/kevinjqliu/iceberg-python/actions/runs/7707078539/job/21003669945

@Fokko Fokko marked this pull request as ready for review February 28, 2024 12:06
@Fokko

Fokko commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

This is great @kevinjqliu 🥳

@Fokko

Fokko commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

@kevinjqliu can you fix this locally, I'm unable to fix this through the UI :/

@kevinjqliu

kevinjqliu commented Feb 29, 2024

Copy link
Copy Markdown
Contributor Author

@Fokko ran make lint locally, should be good now

@Fokko Fokko merged commit a1c6a5a into apache:main Feb 29, 2024
@Fokko

Fokko commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

Thanks for working on this @kevinjqliu

@kevinjqliu kevinjqliu deleted the kevinjqliu/markdown-link-check branch February 29, 2024 15:38
himadripal pushed a commit to himadripal/iceberg-python that referenced this pull request Mar 1, 2024
* add github add to check md link

* Only run under `mkdocs/**`

* ws

* make lint

---------

Co-authored-by: Fokko Driesprong <fokko@apache.org>
@kevinjqliu kevinjqliu mentioned this pull request Mar 2, 2024
@HonahX HonahX added this to the PyIceberg 0.6.1 milestone Mar 27, 2024
HonahX pushed a commit to HonahX/iceberg-python that referenced this pull request Mar 28, 2024
* add github add to check md link

* Only run under `mkdocs/**`

* ws

* make lint

---------

Co-authored-by: Fokko Driesprong <fokko@apache.org>
Fokko added a commit that referenced this pull request Mar 29, 2024
* Github Action to check links in documentation (#324)

* add github add to check md link

* Only run under `mkdocs/**`

* ws

* make lint

---------

Co-authored-by: Fokko Driesprong <fokko@apache.org>

* Fix dead links in docs (#493)
Backport to 0.6.1

---------

Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants