Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/docker-compose-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ services:
retries: 5
start_period: 90s
rest:
image: apache/iceberg-rest-fixture:1.10.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we didnt release a new version of iceberg-rest-fixture for 1.11.0 since there was some license issues. will have to fix forward

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks for pointing that out. We can also go back to the nightlies. We were blocked by the Spark release 👍

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote on using nightlies personally. Hopefully, we don't have a full year between releases, but we're merging a lot of PRs in between releases. It'll be nice to get those in the fixture.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the tag it points at the nightly, which I like since we also know when Java makes a breaking chance of some sort. This happens very rarely.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we disabled nightly as well https://hub.docker.com/r/apache/iceberg-rest-fixture/tags

im trying to fix the docker image: apache/iceberg#16214

image: apache/iceberg-rest-fixture
container_name: pyiceberg-rest
networks:
iceberg_net:
Expand Down
2 changes: 1 addition & 1 deletion dev/spark/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ FROM apache/spark:${BASE_IMAGE_SPARK_VERSION}

# Dependency versions - keep these compatible
# Changing these will invalidate the JAR download cache layer
ARG ICEBERG_VERSION=1.10.1
ARG ICEBERG_VERSION=1.11.0
ARG ICEBERG_SPARK_RUNTIME_VERSION=4.0_2.13
ARG HADOOP_VERSION=3.4.1
ARG AWS_SDK_VERSION=2.24.6
Expand Down
1 change: 0 additions & 1 deletion tests/integration/test_catalog.py

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,6 @@ def test_register_table_existing(test_catalog: Catalog, table_schema_nested: Sch


@pytest.mark.integration
@pytest.mark.skip(reason="Requires Iceberg REST Fixtures 1.11.x")
def test_rest_custom_namespace_separator(rest_catalog: RestCatalog, table_schema_simple: Schema) -> None:
"""
Tests that the REST catalog correctly picks up the namespace-separator from the config endpoint.
Expand Down
Loading