docs: clean OSS and COS configuration tables#3452
Conversation
|
This is replacing #3451 right? Do you mind closing out that other PR? |
| catalog = load_catalog( | ||
| **{ | ||
| "s3.endpoint": "https://cos.ap-guangzhou.myqcloud.com", | ||
| "s3.access-key-id": "admin", | ||
| "s3.secret-access-key": "password", | ||
| } | ||
| ) |
There was a problem hiding this comment.
Does this example truly function without the type or uri properties?
I feel this example doesn't offer much benefit because it's almost a repeat of the table above. We could remove this example.
There was a problem hiding this comment.
thanks for the feedback i removed the example block
| | s3.secret-access-key | password | Secret key for COS | | ||
| | s3.session-token | AQoDYXdzEJr... | Optional session token | | ||
|
|
||
| <!-- markdown-link-check-disable --> |
There was a problem hiding this comment.
It was <!-- markdown-link-check-enable-->. Why did you change it to -disable?
|
|
||
| ### Alibaba Cloud Object Storage Service (OSS) | ||
|
|
||
| <!-- markdown-link-check-disable --> |
|
Fixes #3239 |
|
|
||
| PyIceberg uses [S3FileSystem](https://arrow.apache.org/docs/python/generated/pyarrow.fs.S3FileSystem.html) class to connect to OSS bucket as the service is [compatible with S3 SDK](https://www.alibabacloud.com/help/en/oss/developer-reference/use-amazon-s3-sdks-to-access-oss) as long as the endpoint is addressed with virtual hosted style. | ||
|
|
||
| | Key | Example | Description | |
There was a problem hiding this comment.
nit: There's a bunch of extra formatting changes here that seem unnecessary?
rambleraptor
left a comment
rambleraptor
left a comment
There was a problem hiding this comment.
It would be great if we could get rid of the extra spaces + formatting in the Alibaba section, but the Tencent section sounds great. Thanks for doing this!
3 participants
summary
fixed formatting issues in OSS and Tencent COS configuration documentation
changes
testing