Skip to content

Remove support for catalog_name in table identifier string #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sungwy merged 6 commits into from
Dec 19, 2024
Merged

Remove support for catalog_name in table identifier string #963

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
57093f4
remove catalog identifier
sungwy Dec 19, 2024
9808f94
remove deprecated identifier method
sungwy Dec 19, 2024
166fcd7
lint
sungwy Dec 19, 2024
171a8b2
nit
sungwy Dec 19, 2024
700241c
nit
sungwy Dec 19, 2024
5c52cec
Revert "nit"
sungwy Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pyiceberg/catalog/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@
RecursiveDict,
)
from pyiceberg.utils.config import Config, merge_config
from pyiceberg.utils.deprecated import deprecated, deprecation_message
from pyiceberg.utils.deprecated import deprecated as deprecated
from pyiceberg.utils.deprecated import deprecation_message
Comment thread
sungwy marked this conversation as resolved.

if TYPE_CHECKING:
import pyarrow as pa
Expand Down
17 changes: 2 additions & 15 deletions pyiceberg/table/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@
)
from pyiceberg.utils.concurrent import ExecutorFactory
from pyiceberg.utils.config import Config
from pyiceberg.utils.deprecated import deprecated, deprecation_message
from pyiceberg.utils.deprecated import deprecated
from pyiceberg.utils.deprecated import deprecation_message as deprecation_message
Comment thread
sungwy marked this conversation as resolved.
from pyiceberg.utils.properties import property_as_bool

if TYPE_CHECKING:
Expand Down Expand Up @@ -787,20 +788,6 @@ def refresh(self) -> Table:
self.metadata_location = fresh.metadata_location
return self

@property
def identifier(self) -> Identifier:
"""Return the identifier of this table.

Returns:
An Identifier tuple of the table name
"""
deprecation_message(
deprecated_in="0.8.0",
removed_in="0.9.0",
help_message="Table.identifier property is deprecated. Please use Table.name() function instead.",
)
return (self.catalog.name,) + self._identifier

def name(self) -> Identifier:
"""Return the identifier of this table.

Expand Down