You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore(ci): omit blanket/auto-trait/auto-derived impls from public API (#2542)
#2525 introduced public-api
files but after writing
https://github.com/apache/iceberg-rust/pull/2541/changes I realised this
might be a little too noisy since it incudes all auto-trait like `Send`
`Sync` etc.
Options are:
* -s Omits blanket impls (From<T>, Into<U>, Borrow, Any, etc.)
* -ss Also omits auto-trait impls (Send, Sync, Unpin, Freeze, etc.)
* -sss Also omits auto-derived impls (Clone, Debug, Eq)
I think -sss is enough for reviewers to be made aware of public API
changes without it being so noisy that we don't pay attention to the
actual changes. Downside is it's less "accurate" in the sense that a PR
might introduce a change to the public API that wouldn't be caught in
these tests so there's some sort of balance we need to strike here.
Interested to know what the community thinks.
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes#123` indicates that this PR will close issue #123.
-->
- Closes #.
## What changes are included in this PR?
Pass -sss to cargo-public-api to reduce noise in public-api.txt files.
This removes ~13k lines of auto-generated blanket impls, auto-trait
impls, and auto-derived impls that obscure actual API surface changes in
diffs.
<!--
Provide a summary of the modifications in this PR. List the main changes
such as new features, bug fixes, refactoring, or any other updates.
-->
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
impl<T> tracing::instrument::Instrument for iceberg_catalog_glue::GlueCatalog
65
-
impl<T> tracing::instrument::WithSubscriber for iceberg_catalog_glue::GlueCatalog
66
-
impl<T> typenum::type_operators::Same for iceberg_catalog_glue::GlueCatalog
67
-
pub type iceberg_catalog_glue::GlueCatalog::Output = T
68
-
impl<U> bnum::cast::As for iceberg_catalog_glue::GlueCatalog
69
-
pub fn iceberg_catalog_glue::GlueCatalog::as_<T>(self) -> T where T: bnum::cast::CastFrom<U>
70
-
impl<Unshared, Shared> aws_smithy_runtime_api::shared::IntoShared<Shared> for iceberg_catalog_glue::GlueCatalog where Shared: aws_smithy_runtime_api::shared::FromUnshared<Unshared>
impl<T> tracing::instrument::Instrument for iceberg_catalog_glue::GlueCatalogBuilder
125
-
impl<T> tracing::instrument::WithSubscriber for iceberg_catalog_glue::GlueCatalogBuilder
126
-
impl<T> typenum::type_operators::Same for iceberg_catalog_glue::GlueCatalogBuilder
127
-
pub type iceberg_catalog_glue::GlueCatalogBuilder::Output = T
128
-
impl<U> bnum::cast::As for iceberg_catalog_glue::GlueCatalogBuilder
129
-
pub fn iceberg_catalog_glue::GlueCatalogBuilder::as_<T>(self) -> T where T: bnum::cast::CastFrom<U>
130
-
impl<Unshared, Shared> aws_smithy_runtime_api::shared::IntoShared<Shared> for iceberg_catalog_glue::GlueCatalogBuilder where Shared: aws_smithy_runtime_api::shared::FromUnshared<Unshared>
0 commit comments