Skip to content

feat: forward vended credentials to file_io config #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rlamarche wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: forward vended credentials to file_io config #2300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions crates/catalog/rest/src/catalog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,11 +833,21 @@ impl Catalog for RestCatalog {
}
};

let config = response
let mut config = response
.config
.into_iter()
.chain(self.user_config.props.clone())
.collect();
.collect::<HashMap<String, String>>();

if let Some(storage_credentials) = response.storage_credentials {
for storage_credential in storage_credentials {
if let Some(metadata_location) = &response.metadata_location
&& metadata_location.starts_with(&storage_credential.prefix)
{
config.extend(storage_credential.config.clone());
}
}
}

let file_io = self
.load_file_io(response.metadata_location.as_deref(), Some(config))
Expand Down
Loading