fix(s3tables): use 's3' as the default scheme#2313
Open
rchowell wants to merge 1 commit intoapache:mainfrom
Open
fix(s3tables): use 's3' as the default scheme#2313rchowell wants to merge 1 commit intoapache:mainfrom
rchowell wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
Looks like Java uses s3: as the default https://github.com/apache/iceberg/blob/main/aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java |
dannycjones
reviewed
Apr 5, 2026
dannycjones
left a comment
dannycjones
left a comment
There was a problem hiding this comment.
I believe this is the right change to make. It aligns with the Java catalog and with pre-0.9 behavior.
I'd like to try some testing of the following before a +1 here:
- Trying to create a table or write to a table using 0.9
- Then trying to read that table from this change.
I want to be more confident that we don't break anyone on 0.9.
This was referenced Apr 5, 2026
dannycjones
approved these changes
Apr 5, 2026
dannycjones
left a comment
dannycjones
left a comment
There was a problem hiding this comment.
LGTM, tested this catalog (#2315) to verify it doesn't work at the moment so there shouldn't be anyone impacted upgrading from 0.9.0.
Author
|
Thanks @dannycjones and @xanderbailey for checking this. |
c-thiel
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Changes the s3tables default scheme to "s3://"
Are these changes tested?
With this change, I can read files resolved through an s3table catalog now.