tests(s3tables): add s3tables end-to-end test to verify table creation/loading plus reading/writing#2315
Open
dannycjones wants to merge 1 commit intoapache:mainfrom
Conversation
Author
|
cc @CTTY I'm not sure if this test would be considered superfluous given it's a bit dependent on the underlying storage impl, and only checks that we get as far as missing credential error. I'd prefer some integration tests that actually talk to S3 Tables. |
dannycjones
force-pushed
the
add-test-s3tables-catalog-storage-scheme
branch
from
f1be1d9 to
d77e46d
Compare
…and load tables and read and write their data Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
dannycjones
force-pushed
the
add-test-s3tables-catalog-storage-scheme
branch
from
d77e46d to
9e2ce84
Compare
dannycjones
changed the title
Author
|
I've replaced the original test I wrote which validates that we see "no valid credentials" rather than scheme error instead to prove we can read/write tables end-to-end using this catalog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
In particular, I've written a test that verifies creating a table and writing to it, and then loading that table from the catalog and reading from it using the default storage backend.
What changes are included in this PR?
This adds a test that currently fails and will be passing once #2313 is merged.
Are these changes tested?
This change is only a new test.