Use mise to manage dev tools#2779
Conversation
|
thanks @blackmwk! feel free to tag me when this is ready for review 😄 |
|
I am pretty +1 for this approach, thank you @blackmwk for getting a PR out for this! |
|
One concern I have is that from last community's sync, I can feel that mise is not as ubiquitous as make file, and it may break existing contributor's workflow. |
|
#2793 is a good justification for this change. |
|
@blackmwk is there any remaining changes you are thinking of making before moving this PR out of draft status? |
Yes, it's ready for review. cc @kevinjqliu @Kurtiscwright The introduction of mise makes setting up local dev env easier, also it makes consistent env between ci and local easier, so I believe it's the right direction for long term maintaince. |
CTTY
left a comment
CTTY
left a comment
There was a problem hiding this comment.
Thanks for adding this! I have some minor comments.
I checked several other PRs and noticed that the CI runs much slower with mise compared to ones without. I assume it's because previously we just pulled a prebuilt binary? Can we use mise to pull cargo-binstall to help with this?
|
|
||
| Iceberg Rust is built and tested with stable rust, and will keep a rolling MSRV (minimum supported rust version). | ||
| At least three months from latest rust release is supported. MSRV is updated when we release iceberg-rust. | ||
| Iceberg Rust keeps a rolling MSRV (minimum supported Rust version), currently Rust 1.94. The MSRV is updated when we release iceberg-rust and is at least three months behind the latest Rust release. |
There was a problem hiding this comment.
I have a feeling that Rust 1.94 will easily get outdated without notice. Maybe we should just omit the exact version in README?
There was a problem hiding this comment.
I think putting the exact version in README.md makes our user easier to follow, otherwise we need to ask user to check mise.toml. We could update README.md everytime we upgrade msrv.
| uses: jdx/mise-action@5228313ee0372e111a38da051671ca30fc5a96db # v3.6.3 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| version: 2026.7.5 |
There was a problem hiding this comment.
is this a mise version? I saw different mise versions defined elsewhere, should we make them consistent?
In mise.toml
min_version = "2026.6.14"
There was a problem hiding this comment.
Good catch, fixed all of them.
Good catch, switched to cargo-binstall now |
4 participants
Which issue does this PR close?
What changes are included in this PR?
Using mise instead of make file to manage dev tools.
Are these changes tested?
Local and ci.