fix(glue): Exclude historical schemas from Glue columns#2788
Open
VABVAT wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This PR updates Glue schema conversion so AWS Glue
StorageDescriptor.columnsis populated only from the current Iceberg schema.Previously,
GlueSchemaBuilder::from_icebergconverted the current schema and then also converted historical schemas from table metadata. Those historical fields were written to Glue withiceberg.field.current=false, but Glue does not use that parameter to filter visible columns, which could cause duplicate columns to appear in the Glue Console after schema evolution.Historical schemas are still preserved in Iceberg table metadata. This change only prevents them from being projected into Glue's visible column list.
Are these changes tested?
Yes.
Added a regression test covering schema evolution with historical schemas, and verified the Glue schema output contains only current schema fields.
Ran locally:
cargo test -p iceberg-catalog-glue