Skip to content

Commit 92b5ef3

Browse files
manuzhangmanuzhang
committed
Remove unused classes and methods
1 parent 9002548 commit 92b5ef3

12 files changed

Lines changed: 63 additions & 328 deletions

File tree

‎.palantir/revapi.yml‎

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1178,13 +1178,25 @@ acceptedBreaks:
11781178
new: "class org.apache.iceberg.Metrics"
11791179
justification: "Java serialization across versions is not guaranteed"
11801180
org.apache.iceberg:iceberg-core:
1181+
- code: "java.class.removed"
1182+
old: "class org.apache.iceberg.MetadataUpdate.EnableRowLineage"
1183+
justification: "Removing deprecations for 1.10.0"
11811184
- code: "java.class.removed"
11821185
old: "class org.apache.iceberg.MetadataUpdate.RemoveSnapshot"
11831186
justification: "Removing deprecations for 1.10.0"
1187+
- code: "java.field.removedWithConstant"
1188+
old: "field org.apache.iceberg.TableProperties.ROW_LINEAGE"
1189+
justification: "Removing deprecations for 1.10.0"
1190+
- code: "java.method.removed"
1191+
old: "method boolean org.apache.iceberg.TableMetadata::rowLineageEnabled()"
1192+
justification: "Removing deprecations for 1.10.0"
11841193
- code: "java.method.removed"
11851194
old: "method java.lang.String[] org.apache.iceberg.hadoop.Util::blockLocations(org.apache.iceberg.CombinedScanTask,\
11861195
\ org.apache.hadoop.conf.Configuration)"
11871196
justification: "Removing deprecated code"
1197+
- code: "java.method.removed"
1198+
old: "method long org.apache.iceberg.PartitionStats::totalRecordCount()"
1199+
justification: "Removing deprecations for 1.10.0"
11881200
- code: "java.method.removed"
11891201
old: "method org.apache.iceberg.TableMetadata org.apache.iceberg.TableMetadata::updateSchema(org.apache.iceberg.Schema,\
11901202
\ int)"
@@ -1193,6 +1205,9 @@ acceptedBreaks:
11931205
old: "method org.apache.iceberg.TableMetadata.Builder org.apache.iceberg.TableMetadata.Builder::addSchema(org.apache.iceberg.Schema,\
11941206
\ int)"
11951207
justification: "Removing deprecated code"
1208+
- code: "java.method.removed"
1209+
old: "method org.apache.iceberg.TableMetadata.Builder org.apache.iceberg.TableMetadata.Builder::enableRowLineage()"
1210+
justification: "Removing deprecations for 1.10.0"
11961211
- code: "java.method.removed"
11971212
old: "method org.apache.iceberg.TableMetadata.Builder org.apache.iceberg.TableMetadata.Builder::setStatistics(long,\
11981213
\ org.apache.iceberg.StatisticsFile)"
@@ -1239,6 +1254,54 @@ acceptedBreaks:
12391254
old: "class org.apache.iceberg.data.parquet.BaseParquetWriter<T extends java.lang.Object>"
12401255
new: "class org.apache.iceberg.data.parquet.BaseParquetWriter<T extends java.lang.Object>"
12411256
justification: "Changing deprecated code"
1257+
- code: "java.method.numberOfParametersChanged"
1258+
old: "method <T extends org.apache.iceberg.StructLike> org.apache.iceberg.parquet.ParquetValueWriter<T>\
1259+
\ org.apache.iceberg.data.parquet.InternalWriter<T extends org.apache.iceberg.StructLike>::create(org.apache.parquet.schema.MessageType)"
1260+
new: "method <T extends org.apache.iceberg.StructLike> org.apache.iceberg.parquet.ParquetValueWriter<T>\
1261+
\ org.apache.iceberg.data.parquet.InternalWriter<T extends org.apache.iceberg.StructLike>::create(org.apache.iceberg.types.Types.StructType,\
1262+
\ org.apache.parquet.schema.MessageType)"
1263+
justification: "Removing deprecations for 1.10.0"
1264+
- code: "java.method.numberOfParametersChanged"
1265+
old: "method <T extends org.apache.iceberg.StructLike> org.apache.iceberg.parquet.ParquetValueWriters.StructWriter<T>\
1266+
\ org.apache.iceberg.parquet.ParquetValueWriters::recordWriter(java.util.List<org.apache.iceberg.parquet.ParquetValueWriter<?>>)"
1267+
new: "method <T extends org.apache.iceberg.StructLike> org.apache.iceberg.parquet.ParquetValueWriters.StructWriter<T>\
1268+
\ org.apache.iceberg.parquet.ParquetValueWriters::recordWriter(org.apache.iceberg.types.Types.StructType,\
1269+
\ java.util.List<org.apache.iceberg.parquet.ParquetValueWriter<?>>)"
1270+
justification: "Removing deprecations for 1.10.0"
1271+
- code: "java.method.numberOfParametersChanged"
1272+
old: "method org.apache.iceberg.parquet.ParquetValueReader<T> org.apache.iceberg.data.parquet.InternalReader<T\
1273+
\ extends org.apache.iceberg.StructLike>::createStructReader(java.util.List<org.apache.parquet.schema.Type>,\
1274+
\ java.util.List<org.apache.iceberg.parquet.ParquetValueReader<?>>, org.apache.iceberg.types.Types.StructType)"
1275+
new: "method org.apache.iceberg.parquet.ParquetValueReader<T> org.apache.iceberg.data.parquet.InternalReader<T\
1276+
\ extends org.apache.iceberg.StructLike>::createStructReader(java.util.List<org.apache.iceberg.parquet.ParquetValueReader<?>>,\
1277+
\ org.apache.iceberg.types.Types.StructType)"
1278+
justification: "Removing deprecations for 1.10.0"
1279+
- code: "java.method.numberOfParametersChanged"
1280+
old: "method org.apache.iceberg.parquet.ParquetValueReader<org.apache.iceberg.data.Record>\
1281+
\ org.apache.iceberg.data.parquet.GenericParquetReaders::createStructReader(java.util.List<org.apache.parquet.schema.Type>,\
1282+
\ java.util.List<org.apache.iceberg.parquet.ParquetValueReader<?>>, org.apache.iceberg.types.Types.StructType)"
1283+
new: "method org.apache.iceberg.parquet.ParquetValueReader<org.apache.iceberg.data.Record>\
1284+
\ org.apache.iceberg.data.parquet.GenericParquetReaders::createStructReader(java.util.List<org.apache.iceberg.parquet.ParquetValueReader<?>>,\
1285+
\ org.apache.iceberg.types.Types.StructType)"
1286+
justification: "Removing deprecations for 1.10.0"
1287+
- code: "java.method.numberOfParametersChanged"
1288+
old: "method org.apache.iceberg.parquet.ParquetValueWriters.StructWriter<T>\
1289+
\ org.apache.iceberg.data.parquet.InternalWriter<T extends org.apache.iceberg.StructLike>::createStructWriter(java.util.List<org.apache.iceberg.parquet.ParquetValueWriter<?>>)"
1290+
new: "method org.apache.iceberg.parquet.ParquetValueWriters.StructWriter<T>\
1291+
\ org.apache.iceberg.data.parquet.InternalWriter<T extends org.apache.iceberg.StructLike>::createStructWriter(org.apache.iceberg.types.Types.StructType,\
1292+
\ java.util.List<org.apache.iceberg.parquet.ParquetValueWriter<?>>)"
1293+
justification: "Removing deprecations for 1.10.0"
1294+
- code: "java.method.numberOfParametersChanged"
1295+
old: "method org.apache.iceberg.parquet.ParquetValueWriters.StructWriter<org.apache.iceberg.data.Record>\
1296+
\ org.apache.iceberg.data.parquet.GenericParquetWriter::createStructWriter(java.util.List<org.apache.iceberg.parquet.ParquetValueWriter<?>>)"
1297+
new: "method org.apache.iceberg.parquet.ParquetValueWriters.StructWriter<org.apache.iceberg.data.Record>\
1298+
\ org.apache.iceberg.data.parquet.GenericParquetWriter::createStructWriter(org.apache.iceberg.types.Types.StructType,\
1299+
\ java.util.List<org.apache.iceberg.parquet.ParquetValueWriter<?>>)"
1300+
justification: "Removing deprecations for 1.10.0"
1301+
- code: "java.method.removed"
1302+
old: "method org.apache.iceberg.parquet.ParquetValueWriter<org.apache.iceberg.data.Record>\
1303+
\ org.apache.iceberg.data.parquet.GenericParquetWriter::buildWriter(org.apache.parquet.schema.MessageType)"
1304+
justification: "Removing deprecations for 1.10.0"
12421305
- code: "java.method.removed"
12431306
old: "method void org.apache.iceberg.parquet.ParquetValueReader<T>::setPageSource(org.apache.parquet.column.page.PageReadStore,\
12441307
\ long)"

‎aws/src/main/java/org/apache/iceberg/aws/RESTSigV4Signer.java‎

Lines changed: 0 additions & 160 deletions
This file was deleted.

‎core/src/main/java/org/apache/iceberg/MetadataUpdate.java‎

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -524,17 +524,4 @@ public void applyTo(ViewMetadata.Builder viewMetadataBuilder) {
524524
viewMetadataBuilder.setCurrentVersionId(versionId);
525525
}
526526
}
527-
528-
/**
529-
* Update to enable row lineage.
530-
*
531-
* @deprecated will be removed in 1.10.0; row lineage is required for all v3+ tables.
532-
*/
533-
@Deprecated
534-
class EnableRowLineage implements MetadataUpdate {
535-
@Override
536-
public void applyTo(TableMetadata.Builder metadataBuilder) {
537-
metadataBuilder.enableRowLineage();
538-
}
539-
}
540527
}

‎core/src/main/java/org/apache/iceberg/PartitionStats.java‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,6 @@ public int equalityDeleteFileCount() {
7878
return equalityDeleteFileCount;
7979
}
8080

81-
/**
82-
* @deprecated since 1.9.0, will be removed in 1.10.0, use {@link #totalRecords()} instead.
83-
*/
84-
@Deprecated
85-
public long totalRecordCount() {
86-
return totalRecordCount == null ? 0L : totalRecordCount;
87-
}
88-
8981
public Long totalRecords() {
9082
return totalRecordCount;
9183
}

‎core/src/main/java/org/apache/iceberg/SnapshotProducer.java‎

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -798,37 +798,4 @@ private static void updateTotal(
798798
}
799799
}
800800
}
801-
802-
/**
803-
* A wrapper to set the dataSequenceNumber of a DeleteFile.
804-
*
805-
* @deprecated will be removed in 1.10.0; use {@link Delegates#pendingDeleteFile(DeleteFile,
806-
* Long)} instead.
807-
*/
808-
@Deprecated
809-
protected static class PendingDeleteFile extends Delegates.PendingDeleteFile {
810-
/**
811-
* Wrap a delete file for commit with a given data sequence number.
812-
*
813-
* @param deleteFile delete file
814-
* @param dataSequenceNumber data sequence number to apply
815-
*/
816-
PendingDeleteFile(DeleteFile deleteFile, long dataSequenceNumber) {
817-
super(deleteFile, dataSequenceNumber);
818-
}
819-
820-
/**
821-
* Wrap a delete file for commit with the latest sequence number.
822-
*
823-
* @param deleteFile delete file
824-
*/
825-
PendingDeleteFile(DeleteFile deleteFile) {
826-
super(deleteFile, null);
827-
}
828-
829-
@Override
830-
PendingDeleteFile wrap(DeleteFile file) {
831-
return new PendingDeleteFile(file, dataSequenceNumber());
832-
}
833-
}
834801
}

‎core/src/main/java/org/apache/iceberg/TableMetadata.java‎

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -570,16 +570,6 @@ public TableMetadata withUUID() {
570570
return new Builder(this).assignUUID().build();
571571
}
572572

573-
/**
574-
* Whether row lineage is enabled.
575-
*
576-
* @deprecated will be removed in 1.10.0; row lineage is required for all v3+ tables.
577-
*/
578-
@Deprecated
579-
public boolean rowLineageEnabled() {
580-
return formatVersion >= MIN_FORMAT_VERSION_ROW_LINEAGE;
581-
}
582-
583573
public long nextRowId() {
584574
return nextRowId;
585575
}
@@ -999,22 +989,6 @@ private Builder(TableMetadata base) {
999989
this.nextRowId = base.nextRowId;
1000990
}
1001991

1002-
/**
1003-
* Enables row lineage in v3 tables.
1004-
*
1005-
* @deprecated will be removed in 1.10.0; row lineage is required for all v3+ tables.
1006-
*/
1007-
@Deprecated
1008-
public Builder enableRowLineage() {
1009-
if (formatVersion < MIN_FORMAT_VERSION_ROW_LINEAGE) {
1010-
throw new UnsupportedOperationException(
1011-
"Cannot enable row lineage for format-version=" + formatVersion);
1012-
}
1013-
1014-
// otherwise this is a no-op
1015-
return this;
1016-
}
1017-
1018992
public Builder withMetadataLocation(String newMetadataLocation) {
1019993
this.metadataLocation = newMetadataLocation;
1020994
if (null != base) {

‎core/src/main/java/org/apache/iceberg/TableProperties.java‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -388,11 +388,4 @@ private TableProperties() {}
388388
public static final int ENCRYPTION_DEK_LENGTH_DEFAULT = 16;
389389

390390
public static final int ENCRYPTION_AAD_LENGTH_DEFAULT = 16;
391-
392-
/**
393-
* Property to enable row lineage.
394-
*
395-
* @deprecated will be removed in 1.10.0; row lineage is required for all v3+ tables.
396-
*/
397-
@Deprecated public static final String ROW_LINEAGE = "row-lineage";
398391
}

0 commit comments

Comments
 (0)