[WIP] Core: Add Vortex format to Iceberg#15915
Draft
robert3005 wants to merge 50 commits into
Draft
Conversation
If either half of an OR is an unconvertible expression, we reduce the entire filter to an ALWAYS_TRUE, which means that no filtering is pushed down. This was discovered by the TPC-DS query ``` select * from customer_address where (ca_country = 'United States' AND ca_state IN( 'SC', 'IN', 'VA')) OR (ca_country = 'United States' AND ca_state IN( 'WA', 'KS', 'KY')) ``` The IN expression is not currently pushable, but we can fix that by implementing it in Vortex.
* fix: properly close native resources in Vortex scans * fix system closing * format, bump vortex dep * bump vortex to correct release * remove print
Signed-off-by: Robert Kruszewski <github@robertk.io>
Vortex FF
Merge upstream changes
Update from upstream
Add generic end-to-tend tests for Vortex
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Support case inensitive table scans, and enable TestLocalScan for Vortex
…mn (#31) Support row-idx pushdown into Vortex scans matching the metadata column
Add support for position deletes in Vortex Pushes position deletes into the Vortex scan so deleted rows are excluded natively instead of being read and filtered out afterwards. DeleteFilter exposes the deleted positions for pushdown (skipped when the _is_deleted column is projected, since those rows must be marked rather than removed). GenericReader forwards them only when the reader advertises support via the new ReadBuilder.supportsPositionDeletes(), so Parquet/ORC/Avro keep applying deletes post-scan. VortexIterable serializes the positions as a portable 64-bit Roaring bitmap and applies EXCLUDE_ROARING row selection. Also adds a Vortex position-delete writer (PositionDeleteVortexWriter, VortexFormatModel.forPositionDeletes) for writing path/pos delete files, plus TestVortexPositionDeletes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr isn't meant to be merged in the current state but given that File Format API landed on main I wanted to open the pr to see how Vortex integration in Iceberg would look like and follow up to the community blog post. Had to make couple of adjustments
Vortex can be split on arbitrary row offsets, splitOffsets as defined in the api are purely a read concern and up to the engine/user