Docs: Clarify test method naming guidance#16866
Merged
Merged
Conversation
Generated-by: Codex Co-authored-by: Codex <codex@openai.com>
RussellSpitzer
approved these changes
Jun 18, 2026
Member
|
Any specific reason why a new line is needed for this? I mean I don't mind but what motivated this change? |
singhpk234
approved these changes
Jun 18, 2026
Member
Author
|
@RussellSpitzer It's from @nastra's review comment on another PR, where my codex didn't follow the test method name pattern. |
wombatu-kun
approved these changes
Jun 19, 2026
ebyhr
approved these changes
Jun 19, 2026
ebyhr
left a comment
ebyhr
left a comment
Member
There was a problem hiding this comment.
This change aligns with https://iceberg.apache.org/contribute/#conventions-and-recommendations
chenjian2664
approved these changes
Jun 19, 2026
huaxingao
approved these changes
Jun 20, 2026
Member
Author
|
Thanks everyone for review! |
jakelong95
pushed a commit
to jakelong95/iceberg
that referenced
this pull request
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testprefixes for newly added tests.AI Disclosure
testprefixes for newly added tests.