Skip to content

API: Fix misleading error message in predicate() #16872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thswlsqls wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −1
Open

API: Fix misleading error message in predicate() #16872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d94ff23
API: Fix misleading error message in predicate()
thswlsqls Jun 19, 2026
caac1b7
API: Move predicate unary-op value test to TestExpressionUtil
thswlsqls Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/expressions/Expressions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ public static <T> UnboundPredicate<T> predicate(Operation op, String name, Liter
&& op != Operation.NOT_NULL
&& op != Operation.IS_NAN
&& op != Operation.NOT_NAN,
"Cannot create %s predicate inclusive a value",
"Cannot create %s predicate with a value",
op);
Preconditions.checkArgument(
!NaNUtil.isNaN(lit.value()),
Expand Down
8 changes: 8 additions & 0 deletions api/src/test/java/org/apache/iceberg/expressions/TestExpressionUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.apache.iceberg.expressions;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

Expand Down Expand Up @@ -1452,6 +1453,13 @@ public void testSanitizeVariantObject() {
ExpressionUtil.sanitize(bound));
}

@Test
public void testPredicateWithValueForUnaryOperation() {
assertThatThrownBy(() -> Expressions.predicate(Expression.Operation.IS_NULL, "x", 5))
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("Cannot create IS_NULL predicate with a value");
}

private static VariantPrimitive<?> createTimestampNanos(int primitiveHeader) {
return VariantTestUtil.createSerializedPrimitive(
primitiveHeader,
Expand Down