-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Flink: Fix micros-to-nanos scaling in AvroToRowDataConverters timestamp #17078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
thswlsqls
wants to merge
1
commit into
apache:main
from
thswlsqls:fix/flink-avro-timestamp-micros-nanos
+72
−1
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
...link/src/test/java/org/apache/iceberg/flink/formats/avro/TestAvroToRowDataConverters.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.iceberg.flink.formats.avro; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| import org.apache.avro.Schema; | ||
| import org.apache.avro.SchemaBuilder; | ||
| import org.apache.avro.generic.GenericData; | ||
| import org.apache.avro.generic.GenericRecord; | ||
| import org.apache.flink.table.data.RowData; | ||
| import org.apache.flink.table.data.TimestampData; | ||
| import org.apache.flink.table.types.logical.RowType; | ||
| import org.apache.flink.table.types.logical.TimestampType; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class TestAvroToRowDataConverters { | ||
|
|
||
| private static final long MICROS_PER_MILLI = 1000L; | ||
|
|
||
| // Avro carries timestamps as a plain long; the converter derives precision from the RowType. | ||
| private static final Schema RECORD_SCHEMA = | ||
| SchemaBuilder.record("test").fields().name("ts").type().longType().noDefault().endRecord(); | ||
|
|
||
| private static RowData convertMicros(long micros) { | ||
| RowType rowType = RowType.of(new TimestampType(6)); | ||
| GenericRecord record = new GenericData.Record(RECORD_SCHEMA); | ||
| record.put(0, micros); | ||
| return (RowData) AvroToRowDataConverters.createRowConverter(rowType).convert(record); | ||
| } | ||
|
|
||
| @Test | ||
| public void microsWithSubMillisecondComponent() { | ||
| // micros value with a 123-microsecond leftover that is not aligned to a whole millisecond. | ||
| long micros = 1_577_966_400_000_000L + 123L; | ||
|
|
||
| RowData row = convertMicros(micros); | ||
|
|
||
| long expectedMillis = Math.floorDiv(micros, MICROS_PER_MILLI); | ||
| int expectedNanos = (int) Math.floorMod(micros, MICROS_PER_MILLI) * 1000; | ||
| assertThat(row.getTimestamp(0, 6)) | ||
| .isEqualTo(TimestampData.fromEpochMillis(expectedMillis, expectedNanos)); | ||
| } | ||
|
|
||
| @Test | ||
| public void microsAlignedToMillisecond() { | ||
| // micros value aligned to a whole millisecond (no sub-millisecond component). | ||
| long micros = 1_577_966_400_000_000L; | ||
|
|
||
| RowData row = convertMicros(micros); | ||
|
|
||
| assertThat(row.getTimestamp(0, 6)) | ||
| .isEqualTo(TimestampData.fromEpochMillis(Math.floorDiv(micros, MICROS_PER_MILLI))); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above. |
||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of duplicating what we write in the code to calculate the same values, could we just write the values here?