Spark: Aligned compaction commit filtering between fillQueue methods#17176
Open
sandmannn wants to merge 1 commit into
Open
Spark: Aligned compaction commit filtering between fillQueue methods#17176sandmannn wants to merge 1 commit into
sandmannn wants to merge 1 commit into
Conversation
sandmannn
changed the title
sandmannn
force-pushed
the
fix-compaction-streaming
branch
from
343a088 to
4335d1c
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses concern (3) from #17001
As called out in #17001. The async planner has differnet behavior in
fillQueue(Snapshot readFrom)andfillQueue(fromOffset, toOffset)with regard to the start snapshot. Specifically,fillQueue(fromOffset, toOffset)includes the first snapshot even it is a replacement commit. This PR aligns the behavior to consistnetly drop the replacement commit by calling the same filtering logic that is already used infillQueue(Snapshot readFrom).Added test illustrates the change in the behavior for the async planner: wihtout the change in the
fillQueue, the assertion will objserve the rows not only from the second batch, but also from the first batch added before the timestamp passed into the stream initialization.As this change can be fairly isolated from other issues in #17001, creating a dedicated PR just for this one.
Follow ups
This change addresses the behavior in spark 3.5; can downport to spark 4.0 and 3.5 as a next change.