fix: remove authenticating and add test for login/logout status change

Author: chengxilo

foreign/go/client/tcp/tcp_core_test.go

@@ -274,6 +274,39 @@ func TestNewIggyTcpClient_StoresProvidedLogger(t *testing.T) {
 	}
 }
 
+func TestLoginUser_LoginAndLogout(t *testing.T) {
+	c, serverConn := newTestClient(t)
+
+	identity := make([]byte, 4)
+	binary.LittleEndian.PutUint32(identity, 42)
+
+	go func() {
+		serverRespond(t, serverConn, 0, identity)
+		// login always probes for a leader afterwards; it must be answered or the call blocks.
+		serverRespond(t, serverConn, uint32(ierror.FeatureUnavailableCode), nil)
+		serverRespond(t, serverConn, 0, nil)
+	}()
+
+	ctx := context.Background()
+	info, err := c.LoginUser(ctx, "iggy", "iggy")
+	if err != nil {
+		t.Fatalf("unexpected login error: %v", err)
+	}
+	if info.UserId != 42 {
+		t.Errorf("got user id %d, want 42", info.UserId)
+	}
+	if c.sessionState != iggcon.SessionStateAuthenticated {
+		t.Errorf("expected session %v after login, got %v", iggcon.SessionStateAuthenticated, c.sessionState)
+	}
+
+	if err := c.LogoutUser(ctx); err != nil {
+		t.Fatalf("unexpected logout error: %v", err)
+	}
+	if c.sessionState != iggcon.SessionStateUnauthenticated {
+		t.Errorf("expected session %v after logout, got %v", iggcon.SessionStateUnauthenticated, c.sessionState)
+	}
+}
+
 func TestLoginUser_RejectedReloginKeepsExistingSession(t *testing.T) {
 	c, serverConn := newTestClient(t)
 	c.sessionState = iggcon.SessionStateAuthenticated

foreign/go/client/tcp/tcp_session_management.go

@@ -44,22 +44,12 @@ func (c *IggyTcpClient) LoginWithPersonalAccessToken(ctx context.Context, token
 
 func (c *IggyTcpClient) login(ctx context.Context, loginCmd command.Command) (*iggcon.IdentityInfo, error) {
 	c.logger.Info("Iggy client is signing in...", slog.String("client_address", c.clientAddress))
-	c.mtx.Lock()
-	pre := c.sessionState
-	c.sessionState = iggcon.SessionStateAuthenticating
-	c.mtx.Unlock()
 
+	// A failed login never writes the session state: a server-side reject
+	// leaves the existing session untouched, and a connection that dies
+	// mid-attempt is already reset to unauthenticated by invalidateConnLocked.
 	buffer, err := c.do(ctx, loginCmd)
 	if err != nil {
-		// A rejected login leaves the session state untouched, so restore the
-		// pre-login state only while it is still Authenticating: if the state
-		// moved, the connection may died mid-attempt and invalidation already
-		// recorded it unauthenticated, skip the restoration.
-		c.mtx.Lock()
-		if c.sessionState == iggcon.SessionStateAuthenticating {
-			c.sessionState = pre
-		}
-		c.mtx.Unlock()
 		return nil, err
 	}
 

foreign/go/contracts/state.go

@@ -45,16 +45,13 @@ type SessionState uint8
 
 const (
 	SessionStateUnauthenticated SessionState = iota
-	SessionStateAuthenticating
 	SessionStateAuthenticated
 )
 
 func (s SessionState) String() string {
 	switch s {
 	case SessionStateUnauthenticated:
 		return "unauthenticated"
-	case SessionStateAuthenticating:
-		return "authenticating"
 	case SessionStateAuthenticated:
 		return "authenticated"
 	default: