Skip to content

feat(server-ng): replica rejoin via view probe and message repair#3667

Open
numinnex wants to merge 3 commits into
masterfrom
message_repair_protocol
Open

feat(server-ng): replica rejoin via view probe and message repair#3667
numinnex wants to merge 3 commits into
masterfrom
message_repair_protocol

Conversation

@numinnex

Copy link
Copy Markdown
Contributor

This PR adds the message repair protocol. Additionally it fixes couple of timeout issues during the view change (backup not receiving the RequestStartView was stuck forever).

The message repair protocol streams range of prepares, rather than asking for individual prepare by it's op and checksum. The RequestStartView is also used for probing that triggers the message repair protocol and state transfer in the future.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Jul 13, 2026
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 9.22330% with 748 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.89%. Comparing base (dab12dc) to head (6142dd8).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
core/shard/src/lib.rs 3.61% 373 Missing ⚠️
core/partitions/src/iggy_partition.rs 12.50% 110 Missing and 2 partials ⚠️
core/consensus/src/impls.rs 20.72% 87 Missing and 1 partial ⚠️
core/binary_protocol/src/consensus/header.rs 0.00% 82 Missing ⚠️
core/partitions/src/journal.rs 29.41% 22 Missing and 2 partials ⚠️
core/server_common/src/consensus_message.rs 0.00% 16 Missing ⚠️
core/server-ng/src/bootstrap.rs 0.00% 13 Missing ⚠️
core/shard/src/router.rs 0.00% 12 Missing ⚠️
core/consensus/src/observability.rs 0.00% 10 Missing ⚠️
core/server-ng/src/partition_helpers.rs 23.07% 8 Missing and 2 partials ⚠️
... and 1 more

❌ Your patch check has failed because the patch coverage (9.22%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3667      +/-   ##
============================================
- Coverage     73.48%   72.89%   -0.59%     
  Complexity      937      937              
============================================
  Files          1291     1291              
  Lines        141568   142049     +481     
  Branches     117127   117683     +556     
============================================
- Hits         104029   103549     -480     
- Misses        34312    35197     +885     
- Partials       3227     3303      +76     
Components Coverage Δ
Rust Core 73.05% <9.22%> (-0.65%) ⬇️
Java SDK 62.44% <ø> (ø)
C# SDK 71.05% <ø> (-1.14%) ⬇️
Python SDK 92.17% <ø> (ø)
PHP SDK 84.29% <ø> (ø)
Node SDK 91.22% <ø> (-0.13%) ⬇️
Go SDK 42.28% <ø> (ø)
Files with missing lines Coverage Δ
core/binary_protocol/src/consensus/command.rs 100.00% <100.00%> (ø)
core/consensus/src/vsr_timeout.rs 94.57% <ø> (+0.60%) ⬆️
core/partitions/src/lib.rs 0.00% <ø> (ø)
core/partitions/src/types.rs 27.58% <ø> (ø)
core/server-ng/src/partition_reconciler.rs 86.31% <46.66%> (-0.46%) ⬇️
core/consensus/src/observability.rs 40.08% <0.00%> (-0.92%) ⬇️
core/server-ng/src/partition_helpers.rs 63.52% <23.07%> (-1.84%) ⬇️
core/shard/src/router.rs 0.00% <0.00%> (ø)
core/server-ng/src/bootstrap.rs 10.03% <0.00%> (-0.06%) ⬇️
core/server_common/src/consensus_message.rs 79.78% <0.00%> (-2.91%) ⬇️
... and 5 more

... and 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant