Skip to content

feat(server-ng): replica rejoin via view probe and message repair#3667

Open
numinnex wants to merge 7 commits into
masterfrom
message_repair_protocol
Open

feat(server-ng): replica rejoin via view probe and message repair#3667
numinnex wants to merge 7 commits into
masterfrom
message_repair_protocol

Conversation

@numinnex

@numinnex numinnex commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This PR adds the message repair protocol. Additionally it fixes couple of timeout issues during the view change (backup not receiving the RequestStartView was stuck forever).

The message repair protocol streams range of prepares, rather than asking for individual prepare by it's op and checksum. The RequestStartView is also used for probing that triggers the message repair protocol and state transfer in the future.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Jul 13, 2026
@codecov

codecov Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.42157% with 1023 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.94%. Comparing base (b7c87d8) to head (d412939).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
core/shard/src/lib.rs 4.42% 514 Missing and 4 partials ⚠️
core/partitions/src/iggy_partition.rs 10.52% 185 Missing and 2 partials ⚠️
core/consensus/src/impls.rs 20.72% 87 Missing and 1 partial ⚠️
core/binary_protocol/src/consensus/header.rs 37.50% 55 Missing ⚠️
core/server-ng/src/bootstrap.rs 0.00% 50 Missing ⚠️
core/partitions/src/journal.rs 49.23% 31 Missing and 2 partials ⚠️
core/server-ng/src/segment_recovery.rs 0.00% 31 Missing ⚠️
core/server_common/src/consensus_message.rs 63.41% 8 Missing and 7 partials ⚠️
core/shard/src/router.rs 0.00% 12 Missing ⚠️
core/consensus/src/observability.rs 0.00% 10 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #3667      +/-   ##
============================================
- Coverage     73.61%   72.94%   -0.68%     
  Complexity      937      937              
============================================
  Files          1297     1297              
  Lines        143770   144572     +802     
  Branches     119328   120205     +877     
============================================
- Hits         105842   105451     -391     
- Misses        34562    35658    +1096     
- Partials       3366     3463      +97
Components Coverage Δ
Rust Core 73.08% <16.42%> (-0.76%) ⬇️
Java SDK 62.44% <ø> (ø)
C# SDK 71.04% <ø> (-1.14%) ⬇️
Python SDK 92.17% <ø> (ø)
PHP SDK 84.29% <ø> (ø)
Node SDK 91.22% <ø> (-0.13%) ⬇️
Go SDK 42.71% <ø> (ø)
Files with missing lines Coverage Δ
core/binary_protocol/src/consensus/command.rs 100.00% <100.00%> (ø)
...ore/configs/src/configs_impl/typed_env_provider.rs 90.47% <ø> (ø)
core/consensus/src/vsr_timeout.rs 94.57% <ø> (+0.60%) ⬆️
core/partitions/src/iggy_index.rs 75.00% <100.00%> (-1.14%) ⬇️
core/partitions/src/lib.rs 0.00% <ø> (ø)
core/partitions/src/types.rs 27.58% <ø> (ø)
.../server_common/src/segment_storage/index_writer.rs 75.00% <100.00%> (+1.02%) ⬆️
core/metadata/src/impls/recovery.rs 77.48% <60.00%> (-1.44%) ⬇️
core/server-ng/src/partition_reconciler.rs 86.31% <46.66%> (-0.46%) ⬇️
core/consensus/src/observability.rs 40.08% <0.00%> (-0.92%) ⬇️
... and 10 more

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hubcio
hubcio requested changes Jul 14, 2026
View reviewed changes
Comment thread core/server_common/src/consensus_message.rs
Comment thread core/shard/src/lib.rs
Comment thread core/shard/src/lib.rs
Comment thread core/partitions/src/iggy_partition.rs Outdated
Comment thread core/consensus/src/impls.rs
Comment thread core/shard/src/lib.rs
Comment thread core/partitions/src/journal.rs
Comment thread core/partitions/src/types.rs
Comment thread core/consensus/src/impls.rs
Comment thread core/consensus/src/impls.rs Outdated
@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Jul 14, 2026
@numinnex numinnex force-pushed the message_repair_protocol branch from 272ac9e to b8ae2f3 Compare July 15, 2026 08:39
@numinnex

numinnex commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

/ready

@github-actions github-actions Bot added S-waiting-on-review PR is waiting on a reviewer and removed S-waiting-on-author PR is waiting on author response labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hubcio hubcio hubcio requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@numinnex @hubcio