fix(rust,sdk): stop late offset stores from hitting a left group#3668
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3668 +/- ##
============================================
- Coverage 73.49% 73.25% -0.25%
Complexity 937 937
============================================
Files 1291 1291
Lines 141568 141312 -256
Branches 117128 116944 -184
============================================
- Hits 104046 103512 -534
- Misses 34300 34498 +198
- Partials 3222 3302 +80
🚀 New features to boost your workflow:
|
numinnex
approved these changes
Jul 14, 2026
mmodzelewski
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IntervalOrEach/Each/Every auto-commit modes queue offset stores
through a background channel task instead of storing them inline.
shutdown() left the consumer group right after a direct final
flush, with no idea the channel task still had a backlog. Under
real throughput the backlog landed after the group was already
left, and the broker rejected every one of them as an unknown
group member (5006, consumer_group_member_not_found).
shutdown() now closes the channel and wakes the periodic commit
loop first, awaiting both tasks before leaving the group. The
wait is bounded by a new configurable offset_drain_timeout (5s
default, set via IggyConsumerBuilder). On timeout the task is
aborted outright instead of left detached, so a slow drain can
no longer fire a stale store after the leave call returns.
Also cleared joined_consumer_group unconditionally after the
leave attempt. A failed leave RPC used to leave it stuck true.