Skip to content

Commit 7894034

Browse files
authored
IGNITE-28432 Add storage name to segstore (#7953)
1 parent a333ed6 commit 7894034

10 files changed

Lines changed: 35 additions & 6 deletions

File tree

modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogCheckpointer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ class RaftLogCheckpointer {
6666

6767
RaftLogCheckpointer(
6868
String nodeName,
69+
String storageName,
6970
IndexFileManager indexFileManager,
7071
FailureProcessor failureProcessor,
7172
int maxQueueSize,
@@ -76,7 +77,7 @@ class RaftLogCheckpointer {
7677
this.beforeIndexFileCreated = beforeIndexFileCreated;
7778

7879
queue = new CheckpointQueue(maxQueueSize);
79-
checkpointThread = new IgniteThread(nodeName, "segstore-checkpoint", new CheckpointTask());
80+
checkpointThread = new IgniteThread(nodeName, "segstore-checkpoint-" + storageName, new CheckpointTask());
8081
}
8182

8283
void start() {

modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogGarbageCollector.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ class RaftLogGarbageCollector {
9898

9999
RaftLogGarbageCollector(
100100
String nodeName,
101+
String storageName,
101102
Path segmentFilesDir,
102103
IndexFileManager indexFileManager,
103104
long softLimitBytes,
@@ -110,7 +111,7 @@ class RaftLogGarbageCollector {
110111
this.strategy = strategy;
111112
this.failureProcessor = failureProcessor;
112113

113-
gcThread = new IgniteThread(nodeName, "segstore-gc", new GcTask());
114+
gcThread = new IgniteThread(nodeName, "segstore-gc-" + storageName, new GcTask());
114115
}
115116

116117
void start() throws IOException {

modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/SegmentFileManager.java

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,8 @@ class SegmentFileManager implements ManuallyCloseable {
115115
*/
116116
static final byte[] SWITCH_SEGMENT_RECORD = new byte[8]; // 8 zero bytes.
117117

118+
private final String storageName;
119+
118120
private final Path segmentFilesDir;
119121

120122
/** Number of stripes used by the index memtable. Should be equal to the number of stripes in the Raft server's Disruptor. */
@@ -156,13 +158,18 @@ class SegmentFileManager implements ManuallyCloseable {
156158

157159
SegmentFileManager(
158160
String nodeName,
161+
String storageName,
159162
Path baseDir,
160163
int stripes,
161164
FailureProcessor failureProcessor,
162165
RaftConfiguration raftConfiguration,
163166
LogStorageConfiguration storageConfiguration
164167
) throws IOException {
165-
this.segmentFilesDir = baseDir.resolve("segments");
168+
this.storageName = storageName;
169+
170+
Path storageDir = baseDir.resolve(storageName);
171+
172+
this.segmentFilesDir = storageDir.resolve("segments");
166173
this.stripes = stripes;
167174
this.isSync = raftConfiguration.fsync().value();
168175

@@ -174,10 +181,11 @@ class SegmentFileManager implements ManuallyCloseable {
174181

175182
maxLogEntrySize = maxLogEntrySize(logStorageView);
176183

177-
indexFileManager = new IndexFileManager(baseDir);
184+
indexFileManager = new IndexFileManager(storageDir);
178185

179186
garbageCollector = new RaftLogGarbageCollector(
180187
nodeName,
188+
storageName,
181189
segmentFilesDir,
182190
indexFileManager,
183191
logStorageView.softLogSizeLimitBytes(),
@@ -187,6 +195,7 @@ class SegmentFileManager implements ManuallyCloseable {
187195

188196
checkpointer = new RaftLogCheckpointer(
189197
nodeName,
198+
storageName,
190199
indexFileManager,
191200
failureProcessor,
192201
logStorageView.maxCheckpointQueueSize(),
@@ -195,7 +204,10 @@ class SegmentFileManager implements ManuallyCloseable {
195204
}
196205

197206
void start() throws IOException {
198-
LOG.info("Starting segment file manager [segmentFilesDir={}, fileSize={}].", segmentFilesDir, segmentFileSize);
207+
LOG.info(
208+
"Starting segment file manager [storageName={}, segmentFilesDir={}, fileSize={}].",
209+
storageName, segmentFilesDir, segmentFileSize
210+
);
199211

200212
indexFileManager.cleanupLeftoverFiles();
201213
garbageCollector.cleanupLeftoverFiles();

modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogCheckpointerTest.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,14 @@ class RaftLogCheckpointerTest extends BaseIgniteAbstractTest {
6060

6161
@BeforeEach
6262
void setUp() {
63-
checkpointer = new RaftLogCheckpointer(NODE_NAME, indexFileManager, new NoOpFailureManager(), MAX_QUEUE_SIZE, size -> {});
63+
checkpointer = new RaftLogCheckpointer(
64+
NODE_NAME,
65+
NODE_NAME,
66+
indexFileManager,
67+
new NoOpFailureManager(),
68+
MAX_QUEUE_SIZE,
69+
size -> {}
70+
);
6471

6572
checkpointer.start();
6673
}

modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogGarbageCollectorTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ class RaftLogGarbageCollectorTest extends IgniteAbstractTest {
8989
@BeforeEach
9090
void setUp() throws IOException {
9191
fileManager = new SegmentFileManager(
92+
NODE_NAME,
9293
NODE_NAME,
9394
workDir,
9495
STRIPES,
@@ -411,6 +412,7 @@ void testCleanupLeftoverFilesOnRecovery() throws Exception {
411412
fileManager.close();
412413

413414
fileManager = new SegmentFileManager(
415+
NODE_NAME,
414416
NODE_NAME,
415417
workDir,
416418
STRIPES,
@@ -736,6 +738,7 @@ private void restartSegmentFileManager() throws Exception {
736738
fileManager.close();
737739

738740
fileManager = new SegmentFileManager(
741+
NODE_NAME,
739742
NODE_NAME,
740743
workDir,
741744
STRIPES,

modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogGcSoftLimitTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ class RaftLogGcSoftLimitTest extends IgniteAbstractTest {
8686
@BeforeEach
8787
void setUp() throws IOException {
8888
fileManager = new SegmentFileManager(
89+
NODE_NAME,
8990
NODE_NAME,
9091
workDir,
9192
STRIPES,

modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/SegmentFileManagerGetEntryTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ void setUp(
8383
LogStorageConfiguration storageConfiguration
8484
) throws IOException {
8585
fileManager = new SegmentFileManager(
86+
NODE_NAME,
8687
NODE_NAME,
8788
workDir,
8889
STRIPES,

modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/SegmentFileManagerTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ void setUp() throws IOException {
115115

116116
private SegmentFileManager createFileManager() throws IOException {
117117
return new SegmentFileManager(
118+
NODE_NAME,
118119
NODE_NAME,
119120
workDir,
120121
STRIPES,

modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/SegstoreLogStorageConcurrencyTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ void setUp(
5757
LogStorageConfiguration storageConfiguration
5858
) throws IOException {
5959
segmentFileManager = new SegmentFileManager(
60+
NODE_NAME,
6061
NODE_NAME,
6162
workDir,
6263
1,

modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/SegstoreLogStorageTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ void tearDown() throws Exception {
6060
protected LogStorage newLogStorage() {
6161
try {
6262
segmentFileManager = new SegmentFileManager(
63+
NODE_NAME,
6364
NODE_NAME,
6465
path,
6566
1,

0 commit comments

Comments
 (0)