IGNITE-26775 All uses of Thread Pools replaced with Operation Context aware equivalents

checkstyle/checkstyle-suppressions.xml

@@ -23,7 +23,49 @@
 <suppressions>
     <suppress checks="RightCurly|LeftCurly|EmptyLineSeparator|MethodParamPad|SingleSpaceSeparator"
               files="BCrypt\.java|ConcurrentLinkedDeque8\.java"/>
-    <suppress checks="NoWhitespaceBefore" files="ConcurrentLinkedHashMap\.java"/>
+
+    <suppress checks="NoWhitespaceBefore"
+              files="ConcurrentLinkedHashMap\.java"/>
+
     <suppress checks="LineLength"
               files="ClusterTagGenerator\.java|PagesWriteSpeedBasedThrottle\.java|GridExecutorService\.java|CatboostClassificationModel\.java|classnames\.properties"/>
+
+    <suppress checks="(?&lt;!Missing)JavadocMethod"
+              files="[\\/]internal[\\/]"/>
+
+    <suppress checks="(?&lt;!Missing)JavadocMethod"
+              files="[\\/]test[\\/]"/>
+
+    <suppress checks="(?&lt;!Missing)JavadocMethod"
+              files="[\\/]tests[\\/]"/>
+
+    <suppress checks="(?&lt;!Missing)JavadocMethod"
+              files="[\\/]ml[\\/]"/>
+
+    <suppress checks="(?&lt;!Missing)JavadocMethod"
+              files="[\\/]yardstick[\\/]"/>
+
+    <suppress checks="Javadoc"
+              files="BCrypt\.java|HLL\.java|HLLMetadata\.java|HLLType\.java|BigEndianAscendingWordSerializer\.java|NumberUtil\.java|SchemaVersionOne\.java|BigEndianAscendingWordDeserializer\.java|CacheView\.java|ConcurrentLinkedDeque8\.java|ConcurrentHashMap8\.java|ConcurrentLinkedHashMap\.java"/>
+
+    <suppress checks="org.apache.ignite.tools.checkstyle.ClassUsageRestrictionRule"
+              files="[\\/]yardstick[\\/]"/>
+
+    <suppress checks="org.apache.ignite.tools.checkstyle.ClassUsageRestrictionRule"
+              files="[\\/]internal[\\/]thread[\\/]"/>
+
+    <suppress checks="org.apache.ignite.tools.checkstyle.ClassUsageRestrictionRule"
+              files="[\\/]internal[\\/]jdbc[\\/]thin[\\/]"/>
+
+    <suppress checks="org.apache.ignite.tools.checkstyle.ClassUsageRestrictionRule"
+              files="[\\/]internal[\\/]client[\\/]"/>
+
+    <suppress checks="org.apache.ignite.tools.checkstyle.ClassUsageRestrictionRule"
+              files="[\\/]io[\\/]opencensus[\\/]"/>
+
+    <suppress checks="org.apache.ignite.tools.checkstyle.ClassUsageRestrictionRule"
+              files="[\\/]test[\\/]|[\\/]tests[\\/]"/>
+
+    <suppress checks="org.apache.ignite.tools.checkstyle.ClassUsageRestrictionRule"
+              files="DumpReader\.java|CacheLoadOnlyStoreAdapter\.java"/>
 </suppressions>

checkstyle/checkstyle-xpath-suppressions.xml

@@ -0,0 +1,26 @@
+<?xml version="1.0"?>
+
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+
+<!DOCTYPE suppressions PUBLIC
+    "-//Checkstyle//DTD SuppressionXpathFilter Experimental Configuration 1.2//EN"
+    "https://checkstyle.org/dtds/suppressions_1_2_xpath_experimental.dtd">
+<suppressions>
+    <suppress-xpath checks="AnnotationOnSameLine"
+                    query="//ANNOTATION[.//IDENT[not(@text='Override')]]"/>
+</suppressions>

checkstyle/checkstyle.xml

@@ -24,6 +24,11 @@
 
     <property name="fileExtensions" value="java, properties, xml"/>
 
+    <!-- Suppressions. See: https://checkstyle.sourceforge.io/filters/suppressionfilter.html -->
+    <module name="SuppressionFilter">
+        <property name="file" value="checkstyle/checkstyle-suppressions.xml"/>
+    </module>
+
     <!-- Whitespaces Checks. See: http://checkstyle.sourceforge.net/config_whitespace.html -->
     <module name="FileTabCharacter">
         <property name="eachLine" value="true"/>
@@ -39,6 +44,11 @@
     </module>
 
     <module name="TreeWalker">
+        <!-- Suppressions. See: https://checkstyle.sourceforge.io/filters/suppressionxpathfilter.html -->
+        <module name="SuppressionXpathFilter">
+            <property name="file" value="checkstyle/checkstyle-xpath-suppressions.xml"/>
+        </module>
+
         <!-- Coding Checks. See: https://checkstyle.sourceforge.io/config_coding.html -->
         <module name="SimplifyBooleanExpression"/>
 
@@ -88,10 +98,7 @@
 
         <!-- @Override annotations on the same line with a method declaration check. -->
         <module name="AnnotationOnSameLine" />
-        <module name="SuppressionXpathSingleFilter">
-            <property name="checks" value="AnnotationOnSameLine" />
-            <property name="query" value="//ANNOTATION[.//IDENT[not(@text='Override')]]" />
-        </module>
+
         <!--
             Checks the padding between the identifier of a method definition, constructor definition, method call, or
             constructor invocation; and the left parenthesis of the parameter list.
@@ -172,24 +179,6 @@
         -->
         <module name="JavadocVariable"/>
 
-        <!--
-          Suppresses MissingJavadocMethod check violations in the specified packages.
-          See: https://checkstyle.sourceforge.io/config_filters.html#SuppressionXpathSingleFilter
-       -->
-        <module name="SuppressionXpathSingleFilter">
-            <property name="checks" value="(?&lt;!Missing)JavadocMethod"/>
-            <property name="files" value="[\\/]internal[\\/]|[\\/]test[\\/]|[\\/]tests[\\/]|[\\/]ml[\\/]|[\\/]yardstick[\\/]"/>
-        </module>
-
-        <!--
-          Suppresses all Javadoc check violations in the specified files.
-          See: https://checkstyle.sourceforge.io/config_filters.html#SuppressionXpathSingleFilter
-       -->
-        <module name="SuppressionXpathSingleFilter">
-            <property name="checks" value="Javadoc"/>
-            <property name="files" value="BCrypt\.java|HLL\.java|HLLMetadata\.java|HLLType\.java|BigEndianAscendingWordSerializer\.java|NumberUtil\.java|SchemaVersionOne\.java|BigEndianAscendingWordDeserializer\.java|CacheView\.java|ConcurrentLinkedDeque8\.java|ConcurrentHashMap8\.java|ConcurrentLinkedHashMap\.java"/>
-        </module>
-
         <module name="Indentation" />
 
         <module name="LeftCurly"/>
@@ -200,6 +189,35 @@
 
         <!-- Usage of Ignite abbrevations check. -->
         <module name="org.apache.ignite.tools.checkstyle.IgniteAbbrevationsRule"/>
+
+        <!-- Prevents usage of the particular Java classes in Ignite codebase. -->
+        <module name="org.apache.ignite.tools.checkstyle.ClassUsageRestrictionRule">
+            <property name="className" value="java.util.concurrent.ForkJoinPool"/>
+            <property name="factoryMethods" value="commonPool"/>
+            <property name="substitutionClassName" value="org.apache.ignite.internal.thread.pool.IgniteForkJoinPool"/>
+        </module>
+
+        <module name="org.apache.ignite.tools.checkstyle.ClassUsageRestrictionRule">
+            <property name="className" value="java.util.concurrent.Executors"/>
+            <property name="factoryMethods" value="newFixedThreadPool, newWorkStealingPool, newSingleThreadExecutor, newCachedThreadPool, unconfigurableExecutorService"/>
+            <property name="substitutionClassName" value="org.apache.ignite.internal.thread.IgniteThreadPoolExecutor"/>
+        </module>
+
+        <module name="org.apache.ignite.tools.checkstyle.ClassUsageRestrictionRule">
+            <property name="className" value="java.util.concurrent.Executors"/>
+            <property name="factoryMethods" value="newSingleThreadScheduledExecutor, newScheduledThreadPool, unconfigurableScheduledExecutorService"/>
+            <property name="substitutionClassName" value="org.apache.ignite.internal.thread.pool.IgniteScheduledThreadPoolExecutor"/>
+        </module>
+
+        <module name="org.apache.ignite.tools.checkstyle.ClassUsageRestrictionRule">
+            <property name="className" value="java.util.concurrent.ThreadPoolExecutor"/>
+            <property name="substitutionClassName" value="org.apache.ignite.internal.thread.IgniteThreadPoolExecutor"/>
+        </module>
+
+        <module name="org.apache.ignite.tools.checkstyle.ClassUsageRestrictionRule">
+            <property name="className" value="java.util.concurrent.ScheduledThreadPoolExecutor"/>
+            <property name="substitutionClassName" value="org.apache.ignite.internal.thread.pool.IgniteScheduledThreadPoolExecutor"/>
+        </module>
     </module>
 
     <!--

modules/checkstyle/pom.xml

@@ -72,6 +72,14 @@
             <version>${checkstyle.puppycrawl.version}</version>
         </dependency>
 
+        <dependency>
+            <groupId>com.puppycrawl.tools</groupId>
+            <artifactId>checkstyle</artifactId>
+            <version>${checkstyle.puppycrawl.version}</version>
+            <type>test-jar</type>
+            <scope>test</scope>
+        </dependency>
+
         <dependency>
             <groupId>junit</groupId>
             <artifactId>junit</artifactId>