IGNITE-25712 SQL: Fix key fields wrapping in index for tables created with DDL on existing cache#12452
Open
alex-plekhanov wants to merge 4 commits intoapache:masterfrom
Open
IGNITE-25712 SQL: Fix key fields wrapping in index for tables created with DDL on existing cache#12452alex-plekhanov wants to merge 4 commits intoapache:masterfrom
alex-plekhanov wants to merge 4 commits intoapache:masterfrom
Conversation
|
… with DDL on existing cache
alex-plekhanov
force-pushed
the
ignite-25712
branch
from
bec215f to
8edd767
Compare
… with DDL on existing cache v.2
alex-plekhanov
changed the title
zstan
reviewed
Apr 24, 2026
zstan
reviewed
Apr 24, 2026
| this.cacheInfo = cacheInfo; | ||
| this.typeDesc = typeDesc; | ||
| this.isSql = isSql; | ||
| this.isSql = isSql || typeDesc.sql(); |
Contributor
There was a problem hiding this comment.
probably it will be better to move sql flag into QueryTypeCandidate and reduce such spaghetti code ?
Contributor
Author
There was a problem hiding this comment.
Do you mean QueryTypeCandidate instead of QueryEntityEx? QueryTypeCandidate - it's an runtime entity, it's not stored to PDS and don't used in DynamicCacheDescriptor to pass to other nodes.
… with DDL on existing cache (review fixes)
… with DDL on existing cache (review fixes)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ith DDL on existing cache
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.