IGNITE-27030 Add force flag for rolling upgrade#12513
Merged
timoninmaxim merged 8 commits intoapache:masterfrom Nov 13, 2025
Merged
IGNITE-27030 Add force flag for rolling upgrade#12513timoninmaxim merged 8 commits intoapache:masterfrom
timoninmaxim merged 8 commits intoapache:masterfrom
Conversation
chesnokoff
force-pushed
the
ignite-27030
branch
from
3c4ea35 to
4f29ce2
Compare
chesnokoff
commented
Nov 12, 2025
Comment on lines
-284
to
-293
| private boolean checkVersionsForEnabling(IgniteProductVersion cur, IgniteProductVersion target) throws IgniteCheckedException { | ||
| IgnitePair<IgniteProductVersion> oldVerPair = rollUpVers; | ||
| if (oldVerPair != null) { | ||
| if (oldVerPair.get1().equals(cur) && oldVerPair.get2().equals(target)) | ||
| return false; | ||
|
|
||
| throw new IgniteCheckedException("Rolling upgrade is already enabled with a different current and target version: " + | ||
| oldVerPair.get1() + " , " + oldVerPair.get2()); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
move this out of checkVersionsForEnabling
chesnokoff
force-pushed
the
ignite-27030
branch
from
4f29ce2 to
92453aa
Compare
timoninmaxim
requested changes
Nov 12, 2025
| String targetVerStr = curVer.major() + "." + (curVer.minor() + 1) + "." + (curVer.maintenance() + 1); | ||
| IgniteProductVersion targetVer = IgniteProductVersion.fromString(targetVerStr); | ||
|
|
||
| execute(ROLLING_UPGRADE, ENABLE, targetVerStr, FORCE); |
Member
There was a problem hiding this comment.
Let's check it failed without this flag
|
|
||
| Parameters: | ||
| target_version - Target Ignite version. The target version can be one minor higher if its maintenance version is zero, or one maintenance version higher (e.g. 2.18.0 -> 2.18.1 or 2.18.1 -> 2.19.0). | ||
| --force - Enable rolling upgrade without target version checks. |
Member
There was a problem hiding this comment.
Add a warning, like "do not use without good reason" or smth
| * @param target Target version. | ||
| * @see #enable(IgniteProductVersion, boolean) | ||
| */ | ||
| public void enable(IgniteProductVersion target) throws IgniteCheckedException { |
Comment on lines
-284
to
-293
| private boolean checkVersionsForEnabling(IgniteProductVersion cur, IgniteProductVersion target) throws IgniteCheckedException { | ||
| IgnitePair<IgniteProductVersion> oldVerPair = rollUpVers; | ||
| if (oldVerPair != null) { | ||
| if (oldVerPair.get1().equals(cur) && oldVerPair.get2().equals(target)) | ||
| return false; | ||
|
|
||
| throw new IgniteCheckedException("Rolling upgrade is already enabled with a different current and target version: " + | ||
| oldVerPair.get1() + " , " + oldVerPair.get2()); | ||
| } | ||
|
|
| } | ||
|
|
||
| if (force) | ||
| return true; |
Member
There was a problem hiding this comment.
Let's add log here that we skip checking versions due to force flag
timoninmaxim
approved these changes
Nov 13, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.