Skip to content

IGNITE-27216 Added capturing of cluster node certificates during join process.#12546

Merged
petrov-mg merged 3 commits intoapache:masterfrom
petrov-mg:IGNITE-27216
Dec 10, 2025
Merged

IGNITE-27216 Added capturing of cluster node certificates during join process.#12546
petrov-mg merged 3 commits intoapache:masterfrom
petrov-mg:IGNITE-27216

Conversation

@petrov-mg
Copy link
Copy Markdown
Contributor

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@petrov-mg petrov-mg force-pushed the IGNITE-27216 branch 3 times, most recently from d3ec819 to 7a16f4e Compare December 4, 2025 15:07
/** V2 security subject for authenticated node. */
public static final String ATTR_SECURITY_SUBJECT_V2 = ATTR_PREFIX + ".security.subject.v2";

/** Node certificates with which the connection was established. */
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Node certificates with which the connection was established. */
/** Node certificates the connection was established with. */

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


/** */
private static void enrichNodeWithAttribute(TcpDiscoveryNode node, String attrName, Object attrVal) {
Map<String, Object> attrs = new HashMap<>(node.getAttributes());
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Map<String, Object> attrs = new HashMap<>(node.getAttributes());
if (attrVal == null)
return;
Map<String, Object> attrs = new HashMap<>(node.getAttributes());

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 5, 2025

@petrov-mg petrov-mg merged commit afff124 into apache:master Dec 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants