IGNITE-27678 Same partitions on different nodes can hold different updates if writeThrough is enabled#12666
Open
zstan wants to merge 1 commit into
Open
IGNITE-27678 Same partitions on different nodes can hold different updates if writeThrough is enabled#12666zstan wants to merge 1 commit into
zstan wants to merge 1 commit into
Conversation
zstan
commented
Jan 29, 2026
Vladsz83
reviewed
Feb 1, 2026
zstan
commented
Feb 2, 2026
| private static CountDownLatch nodeKill; | ||
|
|
||
| /** Tx message flag. */ | ||
| private static volatile boolean finalTxMsgPassed; |
Contributor
Author
There was a problem hiding this comment.
it used in static class
zstan
commented
Feb 2, 2026
| private static volatile boolean finalTxMsgPassed; | ||
|
|
||
| /** Session method flag. */ | ||
| private static AtomicBoolean sessionTriggered = new AtomicBoolean(); |
Contributor
Author
There was a problem hiding this comment.
I prefer to store as is.
Vladsz83
reviewed
Feb 2, 2026
| } | ||
| } | ||
| catch (RuntimeException e) { | ||
| U.error(log, "Exception raised during sessionEnd: ", e); |
Contributor
There was a problem hiding this comment.
Let's make the massage more user-friendly. What does it mean, what are the issues?
|
zstan
commented
Mar 13, 2026
| /** {@inheritDoc} */ | ||
| @Override public void onEvent(DiscoveryEvent evt, DiscoCache discoCache) { | ||
| U.awaitQuiet(MapCacheStore.txCoordStoreLatch); | ||
| doSleep(500); |
Contributor
Author
There was a problem hiding this comment.
smell a bit, but still possible race (i believe not in real expluatation) when salvage related code moves faster than common commit flow.
zstan
requested review from
Vladsz83 and
alex-plekhanov
and removed request for
Vladsz83
zstan
force-pushed
the
ignite-27678
branch
2 times, most recently
from
5fbb2eb to
9d8ea16
Compare
…dates if writeThrough is enabled
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are any optimizations\code questions will be raised, first of all this tests need to be checked: