Skip to content

IGNITE-28476 Fix NPE during WalArchiveSizeConfigurationTest#testIncorrectMaxArchiveSizeConfiguration run #12987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zstan merged 2 commits into from
Apr 10, 2026
Merged

IGNITE-28476 Fix NPE during WalArchiveSizeConfigurationTest#testIncorrectMaxArchiveSizeConfiguration run #12987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
371e030
IGNITE-28476 Fix NPE during WalArchiveSizeConfigurationTest#testIncor…
zstan Apr 7, 2026
d9f798a
fix after review
zstan Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...g/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,7 +1126,8 @@ else if (restored != null)
if (defrgMgr != null)
defrgMgr.cancel();

checkpointManager.stop(cancel);
if (checkpointManager != null)
checkpointManager.stop(cancel);

super.onKernalStop0(cancel);

Expand Down
15 changes: 13 additions & 2 deletions .../ignite/internal/processors/cache/persistence/db/wal/WalArchiveSizeConfigurationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import org.apache.ignite.internal.IgniteEx;
import org.apache.ignite.internal.util.typedef.internal.U;
import org.apache.ignite.testframework.ListeningTestLogger;
import org.apache.ignite.testframework.LogListener;
import org.apache.ignite.testframework.junits.WithSystemProperty;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
import org.junit.Test;
Expand Down Expand Up @@ -85,20 +86,30 @@ public void testPersistentConfiguration() throws Exception {
* Checks that an exception is thrown if WAL segment size is larger than max WAL archive size.
*/
@Test
public void testIncorrectMaxArchiveSizeConfiguration() throws Exception {
public void testIncorrectMaxArchiveSizeConfiguration() {
DataStorageConfiguration dataStorageConfiguration = new DataStorageConfiguration()
.setWalSegmentSize((int)U.MB)
.setMaxWalArchiveSize(10)
.setDefaultDataRegionConfiguration(
new DataRegionConfiguration().setPersistenceEnabled(true)
);

ListeningTestLogger listeningLog = new ListeningTestLogger();
LogListener npeChecker = LogListener.matches(NullPointerException.class.getName()).build();
listeningLog.registerListener(npeChecker);

assertThrowsAnyCause(
log,
() -> startGrid(0, (IgniteConfiguration cfg) -> cfg.setDataStorageConfiguration(dataStorageConfiguration)),
() -> startGrid(0, (IgniteConfiguration cfg) ->
cfg
.setDataStorageConfiguration(dataStorageConfiguration)
.setGridLogger(listeningLog)
),
IgniteCheckedException.class,
"maxWalArchiveSize must be no less than"
);

assertFalse(npeChecker.check());
}

/**
Expand Down
Loading