IGNITE-28568 SQL Calcite: Fix sync tx key waiting for DML operations

[alex-plekhanov]

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

• There is a single JIRA ticket related to the pull request.
• The web-link to the pull request is attached to the JIRA ticket.
• The JIRA ticket has the Patch Available state.
• The pull request body describes changes that have been made.
  The description explains WHAT and WHY was made instead of HOW.
• The pull request title is treated as the final commit message.
  The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
• A reviewer has been mentioned through the JIRA comments
  (see the Maintainers list)
• The pull request has been checked by the Teamcity Bot and
  the green visa attached to the JIRA ticket (see tab PR Check at TC.Bot - Instance 1 or TC.Bot - Instance 2)

Notes

• How to Contribute
• Coding abbreviation rules
• Coding Guidelines
• Apache Ignite Teamcity Bot

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

[zstan]

Despite it very necessary fix, let`s run jmh benchmarks before and after this aproach ?

[alex-plekhanov]

@zstan, performance is not affected:
Before:

Benchmark                                     (engine)   Mode  Cnt      Score     Error  Units
JmhSqlDmlBenchmark.insertDeleteBatch           CALCITE  thrpt    3    247,423 ±  13,055  ops/s
JmhSqlDmlBenchmark.insertDeleteUniqueIndexed   CALCITE  thrpt    3   5110,236 ± 225,257  ops/s
JmhSqlDmlBenchmark.updateBatch                 CALCITE  thrpt    3    506,234 ±   2,200  ops/s
JmhSqlDmlBenchmark.updateUniqueIndexed         CALCITE  thrpt    3  10052,103 ± 406,226  ops/s

After:

Benchmark                                     (engine)   Mode  Cnt      Score      Error  Units
JmhSqlDmlBenchmark.insertDeleteBatch           CALCITE  thrpt    3    245,689 ±    7,192  ops/s
JmhSqlDmlBenchmark.insertDeleteUniqueIndexed   CALCITE  thrpt    3   5190,206 ±  118,936  ops/s
JmhSqlDmlBenchmark.updateBatch                 CALCITE  thrpt    3    515,950 ±    9,915  ops/s
JmhSqlDmlBenchmark.updateUniqueIndexed         CALCITE  thrpt    3  10128,092 ±  205,757  ops/s

[sonarqubecloud]

Quality Gate failed

Failed conditions
2 New Code Smells (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE