Skip to content

IGNITE-28584 Fix flaky TooManyOpenFilesTcpCommunicationSpiTest#testTooManyOpenFilesErr #13054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkalkirill merged 1 commit into from
Apr 21, 2026
Merged

IGNITE-28584 Fix flaky TooManyOpenFilesTcpCommunicationSpiTest#testTooManyOpenFilesErr #13054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion ...java/org/apache/ignite/spi/communication/tcp/TooManyOpenFilesTcpCommunicationSpiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.apache.ignite.spi.communication.tcp;

import java.net.SocketException;
import java.util.UUID;
import org.apache.ignite.IgniteCache;
import org.apache.ignite.cluster.ClusterState;
import org.apache.ignite.cluster.ClusterTopologyException;
Expand Down Expand Up @@ -102,7 +103,9 @@ public void testTooManyOpenFilesErr() throws Exception {
nioSrvWrapper.socketChannelFactory(() -> {
throw new SocketException("Too many open files");
});
connPool.forceCloseConnection(txNode.localNode().id());
// Sometimes we can get `org.apache.ignite.IgniteCheckedException: Too many open files` due to parallel
// connection creation, since the forceCloseConnection is for tests, then we can ignore the exception.
forceCloseConnectionSafe(connPool, txNode.localNode().id());

cache.put(1, 2);
cache.put(2, 3);
Expand All @@ -117,4 +120,20 @@ public void testTooManyOpenFilesErr() throws Exception {

assertTrue(waitForCondition(((IgniteKernal)stopNode)::isStopping, 60_000));
}

/** */
private static void forceCloseConnectionSafe(ConnectionClientPool connPool, UUID nodeId) throws Exception {
assertTrue(waitForCondition(() -> {
try {
connPool.forceCloseConnection(nodeId);

return true;
}
catch (Throwable t) {
log.error("Error occurred while attempting to force close connections for node: " + nodeId, t);

return false;
}
}, 10_000));
}
}
Loading